Don't show doc actions when they shouldn't be visible #10651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will check. I see the inlinetab in action on hevuat box but I am having some cors trouble so need to overcome that in order to test. |
|
I see some issues with the build. Will merge the master into it and see if the issue goes away. As I understood from Tobi that should fix it |
petrican
approved these changes
Feb 17, 2021
|
If the build is successful it can be merged. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this was disabled when I did some quick changes to unblock Petrica on his inline tab widget effort. So this looks like a temporary thing that should be reverted.
d97d319#diff-1cfcb26643fbe64684980f1488db853ee0b5abe32b52125ee175f6e9054bd87aL55
@petrican where can the inline tab be tested to be sure it's not affected ?