Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't remove the HU from view after moving it #10711

Merged
merged 1 commit into from
Feb 25, 2021
Merged

don't remove the HU from view after moving it #10711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...e/src/main/java/de/metas/ui/web/handlingunits/process/HUMoveToDirectWarehouseService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,10 +246,12 @@ private void notifyHUMoved(final I_M_HU hu)
//
// Remove this HU from the view
// Don't invalidate. We will do it at the end of all processing.
if (huView != null)
{
huView.removeHUIds(ImmutableSet.of(huId));
}
//
// NOTE/Later edit: we decided to not remove it anymore
// because in some views it might make sense to keep it there.
// The right way would be to check if after moving it, the HU is still elgible for view's filters.
//
// if (huView != null) { huView.removeHUIds(ImmutableSet.of(huId)); }
}

/**
Expand Down