New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Price Comparation report performance improvements #10993
Price Comparation report performance improvements #10993
Conversation
; | ||
|
||
CREATE OR REPLACE FUNCTION report.reportPriceListComparation( | ||
C_BPartner_ID numeric, -- 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please prefix the parameters with p_
pp.seqNo AS SeqNo, | ||
|
||
-- Filter Columns | ||
$1 AS C_BPartner_ID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use name parameters
; | ||
|
||
CREATE OR REPLACE FUNCTION report.reportPriceListComparation_With_PP_PI( | ||
C_BPartner_ID numeric, -- 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as in th other function (please prefix the parameters with p_
)
pp.seqNo AS SeqNo, | ||
|
||
-- Filter Columns | ||
$1 AS C_BPartner_ID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as in th other function (please use parameter-name)
No description provided.