New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShipmentScheduleEnqueuer - directly close the lock when done #11217

Merged

metas-ts merged 5 commits into blonde_monkey_hotfix from blonde_monkey_hotfix_lock

Jun 3, 2021

Member

metas-ts commented Jun 2, 2021

ShipmentScheduleEnqueuer - don't wait for for the lock to be closed async later on
If aquiring a lock fails, select and output the existing locks

metas-ts added 2 commits

June 2, 2021 09:10


          ShipmentScheduleEnqueuer - directly close the lock when done

fe1825f

don't wait for for the lock to be closed async later on


          If locking fails; then output possible pre-exising locks

95eb8a5

teosarca reviewed

View reviewed changes

backend/de.metas.async/src/main/java/de/metas/lock/api/impl/Lock.java Outdated Show resolved Hide resolved

teosarca reviewed

View reviewed changes

backend/de.metas.async/src/main/java/de/metas/lock/api/impl/Lock.java Outdated Show resolved Hide resolved

teosarca reviewed

View reviewed changes

backend/de.metas.async/src/main/java/de/metas/lock/exceptions/LockException.java Show resolved Hide resolved

teosarca reviewed

View reviewed changes

backend/de.metas.async/src/main/java/de/metas/lock/spi/impl/SqlLockDatabase.java Outdated Show resolved Hide resolved

teosarca reviewed

View reviewed changes

backend/de.metas.async/src/main/java/de/metas/lock/spi/impl/SqlLockDatabase.java Outdated Show resolved Hide resolved

teosarca reviewed

View reviewed changes

backend/de.metas.async/src/main/java/de/metas/lock/spi/impl/SqlLockDatabase.java Outdated Show resolved Hide resolved

teosarca reviewed

View reviewed changes

backend/de.metas.async/src/main/java/de/metas/lock/spi/impl/SqlLockDatabase.java Outdated Show resolved Hide resolved

teosarca reviewed

View reviewed changes

backend/de.metas.async/src/main/java/de/metas/lock/spi/impl/SqlLockDatabase.java Outdated Show resolved Hide resolved

teosarca requested changes

View reviewed changes

Member

teosarca left a comment

see my comments


          Follow @teosarca's review; further minor improvements

c4ea6c1

teosarca reviewed

View reviewed changes

backend/de.metas.async/src/main/java/de/metas/lock/api/impl/AbstractLockDatabase.java Outdated Show resolved Hide resolved

metas-ts added 2 commits

June 3, 2021 11:18


          fix bugs; add cucumber-test

e35c17c


          fix bug in DB.retrieveRows, thx @teosarca once more :-)

2fa1308

metas-ts commented

View reviewed changes

Member Author

metas-ts left a comment

lgtm

backend/de.metas.async/src/main/java/de/metas/lock/spi/impl/SqlLockDatabase.java

+              						+ I_T_Lock.COLUMNNAME_IsAllowMultipleOwners
+              						+ " FROM " + I_T_Lock.Table_Name
+              						+ " WHERE " + I_T_Lock.COLUMNNAME_AD_Table_ID + " = " + adTableId.getRepoId()
+              						+ " AND " + whereSql;

Member Author

metas-ts Jun 3, 2021

Suggested change

      
            						+ " AND " + whereSql;
          
            						+ " AND ( " + whereSql + " )";

metas-ts merged commit 2906380 into blonde_monkey_hotfix

metas-ts deleted the blonde_monkey_hotfix_lock branch

June 3, 2021 16:45

metas-ts added branch:blonde_monkey_hotfix type:bug branch:blonde_monkey_uat branch:master in:5.170_release labels

metas-ts added the branch:release label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment