Create API EP for Out-Of-Stock Notice #11271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metas-ts
requested changes
Jun 11, 2021
| @@ -86,6 +87,8 @@ public ShipmentRestController(@NonNull final ShipmentService shipmentService, fi | |||
| } | |||
| catch (final Exception ex) | |||
| { | |||
| Loggables.addLog(ex.getMessage(), ex); | |||
| @@ -288,6 +298,58 @@ private void save(@NonNull final ShipmentSchedule shipmentSchedule) | |||
| return result.build(); | |||
| } | |||
|
|
|||
| public Stream<ShipmentSchedule> streamFromSegment(@NonNull final IShipmentScheduleSegment shipmentScheduleSegment) | |||
| { | |||
| final IQueryBuilder<I_M_ShipmentSchedule> shipmentScheduleIQueryBuilder = queryBL.createQueryBuilder(I_M_ShipmentSchedule.class) | |||
There was a problem hiding this comment.
why didn't you use buildShipmentScheduleWhereClause here? asking because now we have two methods that select shipment schedules from IShipmentScheduleSegments. i'd rather have one..
metas-ts
approved these changes
Jun 14, 2021
...wat/de.metas.swat.base/src/main/java/de/metas/inoutcandidate/ShipmentScheduleRepository.java
Show resolved
Hide resolved
metas-ts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.