Replace BIC by SwiftCode in Revolut Export #12391
Conversation
|
|
||
| UPDATE AD_Column | ||
| SET ColumnName ='SwiftCode' | ||
| WHERE AD_Column_ID = 575110 |
There was a problem hiding this comment.
hmm, this feels awkward because looks like it's done manually.
When changing the column name of an AD_Column i would expect:
- AD_Element_ID to be changed too
- Name, Description, Help to be changed
- AD_Column_Trl records to be changed
- trls to be propagated
There was a problem hiding this comment.
@teosarca see https://github.com/metasfresh/me03/issues/10162#issuecomment-1019892033
the ad_element's ColumnName is 'SwiftCode'
only the AD_Column.ColumnName is BIC. AFAIU someone manually updated it in AD_Column
(so from my pov the sql is ok)
| @@ -148,7 +148,7 @@ private RevolutPaymentExport toRevolutExportRequest(@NonNull final I_C_PaySelect | |||
| .accountNo(bpBankAccount.getAccountNo()) | |||
| .routingNo(bpBankAccount.getRoutingNo()) | |||
| .IBAN(bpBankAccount.getIBAN()) | |||
| .BIC(bpBankAccount.getRoutingNo()) | |||
| .SwiftCode(bpBankAccount.getRoutingNo()) | |||
There was a problem hiding this comment.
it's tricky..
don't we have a dedicated SwitfCode/BIC column in BP Bank account?
i think we do, but we don't display it in the bankaccount window (AD_window_ID=540337), and fixing BIC to SwiftCode already goes beyond the scope..
i'll create an issue..
| @@ -88,7 +88,7 @@ public void compute() | |||
| assertThat(export.getRecipientType()).isEqualTo(RecipientType.COMPANY); | |||
|
|
|||
| assertThat(export.getIBAN()).isEqualTo(bp_bankAccount.getIBAN()); | |||
| assertThat(export.getBIC()).isEqualTo(bp_bankAccount.getRoutingNo()); | |||
| assertThat(export.getSwiftCode()).isEqualTo(bp_bankAccount.getRoutingNo()); | |||
There was a problem hiding this comment.
is this correct? don't we have a dedicated SwitfCode/BIC column in BP Bank account?
| -- URL zum Konzept | ||
| /* DDL */ SELECT public.db_alter_table('Revolut_Payment_Export','ALTER TABLE public.Revolut_Payment_Export ADD COLUMN SwiftCode VARCHAR(20)') | ||
| ; | ||
|
|
There was a problem hiding this comment.
mixing DDL and updates inside one transaction is prone to fail due to pending trigger events.
please either have commit; between the DDL and update statements, or put them into different files
There was a problem hiding this comment.
i prefer separate files!
committing in between it has it's own issues too
| @@ -148,7 +148,7 @@ private RevolutPaymentExport toRevolutExportRequest(@NonNull final I_C_PaySelect | |||
| .accountNo(bpBankAccount.getAccountNo()) | |||
| .routingNo(bpBankAccount.getRoutingNo()) | |||
| .IBAN(bpBankAccount.getIBAN()) | |||
| .BIC(bpBankAccount.getRoutingNo()) | |||
| .SwiftCode(bpBankAccount.getRoutingNo()) | |||
There was a problem hiding this comment.
it's tricky..
don't we have a dedicated SwitfCode/BIC column in BP Bank account?
i think we do, but we don't display it in the bankaccount window (AD_window_ID=540337), and fixing BIC to SwiftCode already goes beyond the scope..
i'll create an issue..
* update to node-16 (cherry picked from commit 7c13a89) (cherry picked from commit 6ec89c9) * Update procurement-webui-frontend dependencies (#12141) * #12140 update dependencies * update to nodejs-16 * #12401 update react-scripts * #12140 fix deps definitely Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> (cherry picked from commit 5b0c590) (cherry picked from commit a1febd3) (cherry picked from commit b5e8156) * Switch other-metasfresh sync to all v2 API (#12148) * solve compile errors when building with java-17 (cherry picked from commit 3729f8f) (cherry picked from commit 1219779) (cherry picked from commit 09dc823) (cherry picked from commit db1ff9b) * Replace BIC by SwiftCode in Revolut Export (#12391) * gh#12397: introduce iban settings for EU countries (#12399) * gh#12397: introduce iban settings for EU countries * #corrections: remove currency update on countries * #12410 add document number for DocType=Eingangsrechnung (#12411) * fix CZ accountnumberlength; add additional tests (#12412) * fix CZ accountnumberlength; add additional failing tests ...to IBANValidationBLTest * iban structure correction * rename migration script * #add iban unit tests Co-authored-by: Chems Eddine Nouioua <chems.nouioua@gmail.com> * #fix migration script... * Data Import Per Bank (#12440) * Data Import Per Bank #12372 * cleanup #12372 * move & docu #12372 * cleanup #12372 * cleanup script #12372 * set default data import #12372 * bank statement import: Bank Fee #12372 * Bank default data import #12372 * bank fee #12372 * display data import in legacy bank window #12372 * ibanTo from same org #12372 * bank fee #12372 * only consider bank accounts that are active #12372 * refactoring #12372 * Import bank statement anvanced field correction #12372 * bank fee corrections (#12450) #12372 * ExternalSystem_Other_ConfigParameter add description column (#12458) * #12410 replace locally generated ID with idserver generated IDs (#12465) * Gh12372 iban same org (#12524) * bank statement import : IBAN from same org #12372 * iban correction #12372 * allow org 0 #12372 * Corrections in invoice cand aggregator (#12625) * Bring back standard invoice cand aggregator #12624 * correction in quality discount aggregator #12624 * invoice candidate qtyToInvoiceBeforeDiscount #12624 (cherry picked from commit 54dc906) * after merge cleanup and fixes * after merge cucumber fix Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> Co-authored-by: Kuba Siemiątkowski <kuba@saskla.cz> Co-authored-by: fp-ps <78536821+fp-ps@users.noreply.github.com> Co-authored-by: Tobias Schöneberg <metas-ts@users.noreply.github.com> Co-authored-by: riadmen <93593841+riadmen@users.noreply.github.com> Co-authored-by: Chems Nouioua <chems.nouioua@gmail.com> Co-authored-by: adi-stefan <60300682+adi-stefan@users.noreply.github.com> Co-authored-by: Ruxandra Craciunescu <ruxandra.craciunescu@metasfresh.com>
No description provided.