order's effective bill-contact - only fall back if consistent #12466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only fall back to the order's AD_User as bill-contact if it's consisten with the order's Bill_Partner
metas-ts
commented
Feb 3, 2022
| @@ -80,11 +80,19 @@ | |||
| */ | |||
| I_AD_User getShipToUser(I_C_Order order); | |||
|
|
|||
| /** | |||
| * @return the order's bill location <b>OR</b> falls back to the "general" contact ({@code C_Order.C_BParter_Location_ID}). | |||
There was a problem hiding this comment.
Suggested change
| * @return the order's bill location <b>OR</b> falls back to the "general" contact ({@code C_Order.C_BParter_Location_ID}). | |
| * @return the order's bill location <b>OR</b> falls back to the "general" location ({@code C_Order.C_BParter_Location_ID}). |
|
|
||
| if (order.getAD_User_ID() <= 0) | ||
| { | ||
| return null; // nothing we can fall back to |
There was a problem hiding this comment.
Suggested change
| return null; // nothing we can fall back to | |
| return null; // nothing we could fall back to |
|
going to integrate now; will keep a keen eye on the scary_plum_hotfix build |
metas-ts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only fall back to the order's AD_User as bill-contact if it's consisten with the order's Bill_Partner