QA/cleanup AD_Schedule manage code #12702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metas-ts
approved these changes
Mar 23, 2022
teosarca
added a commit
that referenced
this pull request
Apr 4, 2022
* drop process SchedulerRunNow * drop process ManageScheduler * move scheduler related classes to de.metas.scheduler * use SchedulerAction instead of ManageSchedulerRequest.Advice * rename from "advice" to "action"
teosarca
added a commit
that referenced
this pull request
Apr 4, 2022
* QA/cleanup AD_Schedule manage code (#12702) * drop process SchedulerRunNow * drop process ManageScheduler * move scheduler related classes to de.metas.scheduler * use SchedulerAction instead of ManageSchedulerRequest.Advice * rename from "advice" to "action" * Window Reference - Tab Used in Process Params (#12703) * On view changed WS event, remove missing rows (#12714) * fix AbstractCustomView.streamByIds to respect the contract, i.e. "If a {@link IViewRow} was not found for given ID, this method simply ignores it." * FE: manually merged the changes from #12280 - On view changed WS event, avoid unnecessary refreshes * fix test (copied from #12280) * webui - Payment Allocation: provide much more simple actions that user can understand (#12715) * SOTrx.ofNullableBoolean * Boolean IParams.getParameterAsBoolean(parameterName, defaultValue) * QA/fix C_Invoice_DiscountAllocation_Process, C_Payment_DiscountAllocation_Process * IParams.getParameterAsInstant * ExplainedOptional.resolve * Amount.toMoney * IAllocationBL: minor QA * fix Money.getCommonCurrencyIdOfAll: tolerate sparse null values add Money.countNonZero * IAllocationBL.invoiceDiscountAndWriteOff * use java Supplier * IPaymentBL.paymentWriteOff - convenient method * InvoiceAmtMultiplier, PaymentAmtMultiplier * C_Invoice_MassDiscountOrWriteOff: refactor/QA * C_Payment_MassWriteOff: refactor/QA * PaymentsViewBasedProcess: getPaymentRowsSelectedForAllocation(), getInvoiceRowsSelectedForAllocation() - cache result * add new allocation processes; remove old ones * PaymentsView_InvoiceDiscountOrWriteOff: fix caption * fix migration scripts * AllocationAmounts.negateIf - make it private * InvoiceAmtMultiplier.convertToRealValue(Money) * Remittance Advice fixes and improvements: consider credit memo invoice too when adjusting the amounts sign * fix test; QA * C_AllocationHdr improvements (#12723) * C_AllocationHdr: more filters * consider PaymentWriteOffAmt when computing ApprovalAmt
cp-ps
added a commit
that referenced
this pull request
Apr 6, 2022
* fix possible inconsistent c_invoice.bpartner_location_ids that might be in older metasfresh DBs #12718 (cherry picked from commit 094e37a) * add volumes to the template (#12732) * #12737 Allow different number of copies for ordercheckup with barcode (#12738) #12737 Allow different number of copies for ordercheckup with barcode * Extend/Change INVOIC EDI for additional requirements fix ftl template * always set invoice-doctype when creating an IC for olc, ol and iol (#12354) * always set invoice-doctype when creating an IC for olc, ol and iol because otherwise, ICs that have no doctype but will get the standard-invoice-doctype are not added to the same invoices as similar ICs that already explicitly have this doctype * Set target invoice doctype to Flatrate invoice candidate #12475 Co-authored-by: metas_rc <ruxandra.craciunescu@metasfresh.com> (cherry picked from commit ac55bac) * excel-pricelist: export and import differing dropship partners (#12746) optionally export and import differing dropship partners #12742 * fix error in case no override-bpartner was set #12580 * scary_plum_hotfix: Payment Allocation improvements (#12763) * QA/cleanup AD_Schedule manage code (#12702) * drop process SchedulerRunNow * drop process ManageScheduler * move scheduler related classes to de.metas.scheduler * use SchedulerAction instead of ManageSchedulerRequest.Advice * rename from "advice" to "action" * Window Reference - Tab Used in Process Params (#12703) * On view changed WS event, remove missing rows (#12714) * fix AbstractCustomView.streamByIds to respect the contract, i.e. "If a {@link IViewRow} was not found for given ID, this method simply ignores it." * FE: manually merged the changes from #12280 - On view changed WS event, avoid unnecessary refreshes * fix test (copied from #12280) * webui - Payment Allocation: provide much more simple actions that user can understand (#12715) * SOTrx.ofNullableBoolean * Boolean IParams.getParameterAsBoolean(parameterName, defaultValue) * QA/fix C_Invoice_DiscountAllocation_Process, C_Payment_DiscountAllocation_Process * IParams.getParameterAsInstant * ExplainedOptional.resolve * Amount.toMoney * IAllocationBL: minor QA * fix Money.getCommonCurrencyIdOfAll: tolerate sparse null values add Money.countNonZero * IAllocationBL.invoiceDiscountAndWriteOff * use java Supplier * IPaymentBL.paymentWriteOff - convenient method * InvoiceAmtMultiplier, PaymentAmtMultiplier * C_Invoice_MassDiscountOrWriteOff: refactor/QA * C_Payment_MassWriteOff: refactor/QA * PaymentsViewBasedProcess: getPaymentRowsSelectedForAllocation(), getInvoiceRowsSelectedForAllocation() - cache result * add new allocation processes; remove old ones * PaymentsView_InvoiceDiscountOrWriteOff: fix caption * fix migration scripts * AllocationAmounts.negateIf - make it private * InvoiceAmtMultiplier.convertToRealValue(Money) * Remittance Advice fixes and improvements: consider credit memo invoice too when adjusting the amounts sign * fix test; QA * C_AllocationHdr improvements (#12723) * C_AllocationHdr: more filters * consider PaymentWriteOffAmt when computing ApprovalAmt * Column names containing "PW" should be considered passwords (#12725) * Column names containing "PW" should be considered passwords #12724 * Column names ending with "PW" should be considered passwords. Also, EMail_From_Pwd is a password #12724 (cherry picked from commit 8ba4723) * after merge cleanup Co-authored-by: Tobias Schöneberg <metas-ts@users.noreply.github.com> Co-authored-by: Cristina Ghita <cristina.ghita@metasfresh.com> Co-authored-by: Teo Sarca <teo.sarca@metasfresh.com> Co-authored-by: Ruxandra Craciunescu <ruxandra.craciunescu@metasfresh.com>
cp-ps
added a commit
that referenced
this pull request
Apr 20, 2022
* fix possible inconsistent c_invoice.bpartner_location_ids that might be in older metasfresh DBs #12718 (cherry picked from commit 094e37a) * add volumes to the template (#12732) * #12737 Allow different number of copies for ordercheckup with barcode (#12738) #12737 Allow different number of copies for ordercheckup with barcode * Extend/Change INVOIC EDI for additional requirements fix ftl template * always set invoice-doctype when creating an IC for olc, ol and iol (#12354) * always set invoice-doctype when creating an IC for olc, ol and iol because otherwise, ICs that have no doctype but will get the standard-invoice-doctype are not added to the same invoices as similar ICs that already explicitly have this doctype * Set target invoice doctype to Flatrate invoice candidate #12475 Co-authored-by: metas_rc <ruxandra.craciunescu@metasfresh.com> (cherry picked from commit ac55bac) * excel-pricelist: export and import differing dropship partners (#12746) optionally export and import differing dropship partners #12742 * fix error in case no override-bpartner was set #12580 * scary_plum_hotfix: Payment Allocation improvements (#12763) * QA/cleanup AD_Schedule manage code (#12702) * drop process SchedulerRunNow * drop process ManageScheduler * move scheduler related classes to de.metas.scheduler * use SchedulerAction instead of ManageSchedulerRequest.Advice * rename from "advice" to "action" * Window Reference - Tab Used in Process Params (#12703) * On view changed WS event, remove missing rows (#12714) * fix AbstractCustomView.streamByIds to respect the contract, i.e. "If a {@link IViewRow} was not found for given ID, this method simply ignores it." * FE: manually merged the changes from #12280 - On view changed WS event, avoid unnecessary refreshes * fix test (copied from #12280) * webui - Payment Allocation: provide much more simple actions that user can understand (#12715) * SOTrx.ofNullableBoolean * Boolean IParams.getParameterAsBoolean(parameterName, defaultValue) * QA/fix C_Invoice_DiscountAllocation_Process, C_Payment_DiscountAllocation_Process * IParams.getParameterAsInstant * ExplainedOptional.resolve * Amount.toMoney * IAllocationBL: minor QA * fix Money.getCommonCurrencyIdOfAll: tolerate sparse null values add Money.countNonZero * IAllocationBL.invoiceDiscountAndWriteOff * use java Supplier * IPaymentBL.paymentWriteOff - convenient method * InvoiceAmtMultiplier, PaymentAmtMultiplier * C_Invoice_MassDiscountOrWriteOff: refactor/QA * C_Payment_MassWriteOff: refactor/QA * PaymentsViewBasedProcess: getPaymentRowsSelectedForAllocation(), getInvoiceRowsSelectedForAllocation() - cache result * add new allocation processes; remove old ones * PaymentsView_InvoiceDiscountOrWriteOff: fix caption * fix migration scripts * AllocationAmounts.negateIf - make it private * InvoiceAmtMultiplier.convertToRealValue(Money) * Remittance Advice fixes and improvements: consider credit memo invoice too when adjusting the amounts sign * fix test; QA * C_AllocationHdr improvements (#12723) * C_AllocationHdr: more filters * consider PaymentWriteOffAmt when computing ApprovalAmt * Column names containing "PW" should be considered passwords (#12725) * Column names containing "PW" should be considered passwords #12724 * Column names ending with "PW" should be considered passwords. Also, EMail_From_Pwd is a password #12724 (cherry picked from commit 8ba4723) * refs: #12808 fix procurement-webui-frontend build fail (#12809) * add yarn.lock (#12811) * #12737 Choose to differentiate based on Document type (#12836) * #12737 Choose to differentiate based on Document type #12737 Allow different number of copies for ordercheckup with barcode * #12737 Minor * #12737 add non null * #12737 Minor refactoring * #12737 Fix compiling issue * after merge cleanup * after merge cleanup Co-authored-by: Tobias Schöneberg <metas-ts@users.noreply.github.com> Co-authored-by: Cristina Ghita <cristina.ghita@metasfresh.com> Co-authored-by: Teo Sarca <teo.sarca@metasfresh.com> Co-authored-by: Ruxandra Craciunescu <ruxandra.craciunescu@metasfresh.com> Co-authored-by: fp-ps <78536821+fp-ps@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
de.metas.schedule)