Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raw Products Sales Computing method #17903

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Raw Products Sales Computing method #17903

merged 5 commits into from
Apr 23, 2024

Conversation

cp-ps
Copy link
Contributor

@cp-ps cp-ps commented Apr 22, 2024

@dm-ps dm-ps mentioned this pull request Apr 22, 2024
Merged
mrie04
mrie04 requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@mrie04 mrie04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check my comments

...de/metas/contracts/modular/computing/purchasecontract/sales/raw/RawSalesComputingMethod.java Outdated Show resolved Hide resolved
@mrie04 mrie04 added the ops:dont_auto_merge This label can be set for mergify to not automatically merge a PR, if it's green and approved label Apr 23, 2024
mrie04
mrie04 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@mrie04 mrie04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teosarca teosarca removed the ops:dont_auto_merge This label can be set for mergify to not automatically merge a PR, if it's green and approved label Apr 23, 2024
@cp-ps
add translations
182d77e
@cp-ps
Merge branch 'inner_silence_uat' into inner_silence_uat_gh17902
66a02de 
# Conflicts:
#	backend/de.metas.contracts/src/main/java/de/metas/contracts/modular/log/ModularContractLogDAO.java
@cp-ps cp-ps merged commit 80b4bbb into inner_silence_uat Apr 23, 2024
8 of 10 checks passed
@cp-ps cp-ps deleted the inner_silence_uat_gh17902 branch April 23, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teosarca teosarca teosarca left review comments

@mrie04 mrie04 mrie04 approved these changes

Assignees
No one assigned
Labels
branch:inner_silence_uat branch:master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cp-ps @teosarca @mrie04 @metas-rc