5040-app Accounting for Payment Allocation and Vendor Credit Memo wrong #5054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createPaymentFacts - @teosarca chinese-roomed me into fixing this issue by taking dedicated care of each one of the four combinations of SO/PO and Regular/CreditMemo Basically, this is a "manual" cherry-pick of applicable parts of 639974d Accounting for Payment Allocation and Vendor Credit Memo wrong #5040
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also handle the case for purchase credit memos with writeoff and discount
Basically, this is a "manual" cherry-pick of 173c441
Accounting for Payment Allocation and Vendor Credit Memo wrong #5040