Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5522-app - Commission calculation ][ #5726

Merged
merged 2 commits into from Oct 28, 2019
Merged

5522-app - Commission calculation ][ #5726

merged 2 commits into from Oct 28, 2019

Conversation

metas-ts
Copy link
Member

@metas-ts
5522-app - Commission calculation
8086aba 
- extend settings with product category and bpartner group (both optional)
#5522
@metas-ts
5522-app - Commission calculation
ff6a84a 
- CommissionConfigStagingDataService: fix caching for commission config lines
- FlatrateDAO: fix flatrate term retrieval if no product/productcategory or charge is given and the conditions has no flatrate-matching records
#5522
metas-ts
metas-ts commented Oct 28, 2019
View reviewed changes
Copy link
Member Author

@metas-ts metas-ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok for tomorrow's demo; need to also do more testing now

@metas-ts metas-ts marked this pull request as ready for review October 28, 2019 16:12
@metas-ts metas-ts merged commit 4cdd10b into master Oct 28, 2019
@metas-ts metas-ts deleted the gh5522-app_2 branch October 28, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@metas-ts