Hide DocType with name ** Neu **
#6367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metas-ts
requested changes
Mar 19, 2020
There was a problem hiding this comment.
- only editing the DDL is not enugh. you need to add a migr-script too
- i think it's better to stick with the left join and simply add the
AND dt.c_doctype_id != 0to theON - occuring to me only now: taxName, taxCategoryName and docTypeName lack
_TRL. please clarify with mark if it's needed
This time using the left join instead of a subselect #6121
|
I forgot to add migration script, sorry 'bout that. Added the translations. |
metas-ts
approved these changes
Mar 19, 2020
metas-ts
pushed a commit
that referenced
this pull request
Mar 19, 2020
* Hide DocType with name `** Neu **` #6121 * Revert "Hide DocType with name `** Neu **`" This reverts commit a492582 #6121 * Hide DocType with name `** Neu **` This time using the left join instead of a subselect #6121 * Update DocType, Tax and TaxCategory to use TRL #6121 * Add migration file #6121 (cherry picked from commit 9783292)
metas-ts
pushed a commit
that referenced
this pull request
Mar 19, 2020
* Hide DocType with name `** Neu **` #6121 * Revert "Hide DocType with name `** Neu **`" This reverts commit a492582 #6121 * Hide DocType with name `** Neu **` This time using the left join instead of a subselect #6121 * Update DocType, Tax and TaxCategory to use TRL #6121 * Add migration file #6121 (cherry picked from commit 9783292)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6121