Cash Journal: Doubled lines after complete and Payment link to wrong line/wrong cashbook #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBestPessimist
force-pushed
the
gh6547-cash-journal
branch
from
1324d56
to
0482e08
Compare
…ct when creating Payment from BankStatementLine #6547
TheBestPessimist
force-pushed
the
gh6547-cash-journal
branch
from
3ffa2ec
to
0c5481e
Compare
metas-ts
approved these changes
May 5, 2020
| { | ||
| if (bsl.getC_BP_BankAccountTo_ID() <= 0) | ||
| { | ||
| bsl.setLink_BankStatementLine_ID(0); | ||
| } | ||
| } | ||
|
|
||
| @CalloutMethod(columnNames = I_C_BankStatementLine.COLUMNNAME_C_Invoice_ID) |
There was a problem hiding this comment.
it's OK to follow the naming convention within this class, but otherwise please prefer a method name that descripbes what the method does, rather than when it's invoked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6547