Gh6566 2 customer retention: repair logic, refactoring, test #6593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 22bfa13.
metas-ts
requested changes
May 7, 2020
| @@ -64,13 +68,18 @@ | |||
| private final IInvoiceDAO invoiceDAO = Services.get(IInvoiceDAO.class); | |||
| private final IContractsDAO contractsDAO = Services.get(IContractsDAO.class); | |||
| private final ContractInvoiceService contractInvoiceService; | |||
|
|
|||
|
|
|||
| public I_C_Customer_Retention getById(final CustomerRetentionId customerRetentionId) | |||
There was a problem hiding this comment.
pls add @NonNull at least to public methods like this one
| { | ||
| customerRetention = createNewCustomerRetention(bpartnerId); | ||
| } | ||
| final I_C_Customer_Retention customerRetention = getById(customerRetentionId); | ||
|
|
There was a problem hiding this comment.
please add a comment or better an Check.assumeNotNull here to make it explicit the you made sure elsewhere this won't be null
PS: if you need to rely on something outside this class, such as the model interceptors, i suggest to invoke that getCreate createUpdate method instead..
There was a problem hiding this comment.
Check.assumeNotNull done.
metas-ts
approved these changes
May 7, 2020
metas-ts
pushed a commit
that referenced
this pull request
May 7, 2020
(cherry picked from commit a5862f5) solved Conflicts: backend/de.metas.contracts/src/main/java/de/metas/contracts/impl/CustomerRetentionRepository.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6566