New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DocList and it's child components #6700

Merged

siemiatj merged 4 commits into master from frontend-6666

May 21, 2020

Contributor

siemiatj commented May 20, 2020

Remove some unnecessary imports, empty objects/arrays, props etc. This limits the number of re-renders by a great deal.

Related to #6666

Tested on a sales order list with one order when logging renders, and on w101 for performance tests.

Before:

After:


          #6666 refactor DocList and child components

ee01a52

remove unnecessary object references, empty objects, imports etc

siemiatj requested a review from petrican

May 20, 2020 14:10


          #6666 fix linter errors

23b1016

petrican suggested changes

View reviewed changes

Contributor

petrican left a comment

Good job! Pls try to do the small requested changes. Thank you

frontend/src/components/header/SubHeader.js Outdated Show resolved Hide resolved

frontend/src/containers/DocList.js Show resolved Hide resolved

frontend/src/containers/DocList.js Show resolved Hide resolved

frontend/src/containers/DocList.js Outdated Show resolved Hide resolved

frontend/src/containers/DocList.js Outdated Show resolved Hide resolved

teosarca reviewed

View reviewed changes

frontend/src/components/Container.js Show resolved Hide resolved

teosarca reviewed

View reviewed changes

frontend/src/components/Container.js Outdated Show resolved Hide resolved

teosarca reviewed

View reviewed changes

frontend/src/components/header/Header.js Outdated Show resolved Hide resolved

teosarca reviewed

View reviewed changes

frontend/src/containers/DocList.js Show resolved Hide resolved

teosarca reviewed

View reviewed changes

frontend/src/utils/documentListHelper.js Show resolved Hide resolved


          #6666 review cleanup

87fd866

- rename `windowType` to `windowId`
- comments
- remove anonymous function for ref assignment

siemiatj requested review from petrican and teosarca

May 21, 2020 09:47

petrican approved these changes

View reviewed changes

Contributor

petrican left a comment

lgtm. Thanks

Contributor

petrican commented May 21, 2020

pls fix the linter err. Thanks


          #6666 fix lint error

8ac3e5d

siemiatj merged commit 9cb1fbd into master

siemiatj deleted the frontend-6666 branch

June 8, 2020 13:18

BodorAnnamaria added a commit that referenced this pull request


          #6700 Add C_BPartner_Location.Setup_Place_No column

80f71c1

#10515
The column is displayed in
- window 123
- window 53025, record 540396

#10515

BodorAnnamaria added a commit that referenced this pull request


          #6700 Add C_BPartner_Location.Setup_Place_No column

5bbef22

#10515
- clean script
- add models

BodorAnnamaria added a commit that referenced this pull request


          #6700 Add C_BPartner_Location.Setup_Place_No column

a4d4c39

#10515
- clean script
- add models

BodorAnnamaria added a commit that referenced this pull request


          #6700 Add C_BPartner_Location.Setup_Place_No column

b8ede56

#10515
- create column
- add models

BodorAnnamaria added a commit that referenced this pull request


          #6700 Add C_BPartner_Location.Setup_Place_No column (#10520)

af81b42

* #6700 Add C_BPartner_Location.Setup_Place_No column
#10515
The column is displayed in
- window 123
- window 53025, record 540396

#10515

* #6700 Add C_BPartner_Location.Setup_Place_No column
#10515
- clean script
- add models

* (6700) EDI Coop - Geschäftsfall X mit Stückware
#10515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment