Fix accidental inactivation of not-IBAN bank accounts #6799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
metas-ts
commented
Jun 4, 2020
metas-ts
commented
- basically the fix is to not deactivate C_BP_BankAccounts that have no IBAN, because those
- are not loaded into the bpartnercomposite and the API can't access them anyways
- would otherwise always be deactiaved
- application.properties: unrelated cleanup
* basically the fix is to not deactivate C_BP_BankAccounts that have no IBAN, because those * are not loaded into the bpartnercomposite and the API can't access them anyways * would otherwise always be deactiaved * application.properties: unrelated cleanup
metas-ts
added a commit
that referenced
this pull request
Jun 4, 2020
manually porting the changes from master commit 58f0e4d
metas-ts
added a commit
that referenced
this pull request
Jun 4, 2020
(cherry picked from commit 58f0e4d)
metas-ts
added a commit
that referenced
this pull request
Jun 4, 2020
manually porting the changes from master commit 58f0e4d
siemiatj
added a commit
that referenced
this pull request
Jun 17, 2020
* Add fixes for dates depending on the locale #6712 (#6715) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Add fixes for dates depending on the locale #6712 (#6715) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> (cherry picked from commit c388007) * #6615 comment out credit memo after partial request (#6728) * Gh6615 4 add process description (#6733) * Gh6615 5 rename migration file (#6736) * #6615 comment out credit memo after partial request #6615 * #6615 delete unneeded code and refactoring warning message #6615 * #6615 don't assume anything on this level. The user will make they needed changes. #6615 * #6615 update CreateCreditMemo process description #6615 * #6615 Allow the user to allocate as much as they want on a credit memo #6615 * #6615 Cleanup the code. * The old partial credit memo handling is no longer needed so we decided to drop it completely, not keep it for docu purposes. #6615 * #6615 update process description #6615 * #6615 rename script #6615 * Gh6743 uom conversion with round UP (#6744) * when converting quantities, round up * #6743 repair the tests to fit the new rounding mode #6743 Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> * #6615 null check in pay selection updater #6615 * #6718 Fix uomconvertdirect.sql and MD_Stock_From_HUs_V.sql (#6755) (cherry picked from commit 2259f58) * #6718 fix case of missing MD_Stock records * Window Distribution Order enhancements (#6752) * Window Distribution Order enhancements refs: #6713 * 6723 table tests (#6773) * Fix formatting in the config and fixed import #6723 * Reordered the structure for the fixtures #6732 * Test the props passed #6723 * Add test with store data #6723 * Remove debug line #6723 * Table status update check #6723 * Base TableCell tests #6723 * Skel for TableContextMenu #6723 * Removed comment from #6723 * Added eventsourcemock and settings in jest for the TableContextMenu #6723 * Test if TableContextMenu is rendering properly #6723 * More unit tests added to TableContextMenu #6723 * Add fixture for the EntryTable component #6723 * Added skel for the EntryTable tests #6723 * Small fix to ditch the warnings complaining about required fncts #6723 * Managed to do fixes to the mockup in order to render properly the component #6732 * Fix linter err * Added fixture for the TableFilter #6723 * Basic tests for rendering TestingFilter #6723 * Fixtures for the TableHeader #6723 * Small fixes in the TableItem #6723 * Add unit tests for the TableHeader #6723 * Prettier formatting #6723 * Fixtures for table pagination * Base test for TablePagination #6723 * Test active page #6723 * Pagination tests selection #6723 * TablePagination compressed tests #6723 * Added fixtures for the TableQuickInput #6723 * TableQuickInput basic rendering test #6723 * Removed debug Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * `Payment Allocation` action shall open also when Payments not available (#6776) * #6777 Shall refresh even if is single document (#6778) * #6777 Shall refresh even if is single document * minor: add comments Co-authored-by: Tobias Schöneberg <metas-ts@users.noreply.github.com> * #6777 Repair process refresh - invalidate documents (#6781) * moved to callout (#6748) #6745 * Show scrollbar when exceeds the visible area #6687 (#6775) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Update metasfresh-dist-serverRoot_jrebel.launch * #6785 don't spread `this.state` when setting state (#6786) * Master manual invoice (#6787) * Fix unit tests (#6788) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Better error handling in tabs (#6789) * #6713 Fixed minor details. (#6793) * #6794 Changed font size and unbolded it. (#6795) * gh6784_3_ic (#6792) * AllocationAmounts.toString() improvements (i.e. make it shorter) * fix PaymentsViewAllocateCommand.toPayableDocument + tests #6784 * #6779 Now sending 0 instead of null to frontend in the case we receive 0 for the qty to invoice override field. (#6780) * #6779 Now sending 0 instead of null to frontend in the case we receive 0 for the qty to invoice override field. * Set the null value when we have no number in the input Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Add fixes for dates depending on the locale #6712 (#6715) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> (cherry picked from commit c388007) * Fix accidental inactivation of not-IBAN bank accounts (#6799) * Fix accidental inactivation of not-IBAN bank accounts (#6799) (cherry picked from commit 58f0e4d) * Fix accidental inactivation of not-IBAN bank accounts (#6799) manually porting the changes from master commit 58f0e4d * Wrong Organisation set to HUs when doing Inventory or Material Receipt (#6783) Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> * set C_Invoice_Candidate.ApprovalForInvoicing=Y when enqueing for invoicing (#6768) #6767 * set C_Invoice_Candidate.ApprovalForInvoicing=Y when enqueing for invoicing (#6768) #6767 * Gh6769 (#6770) * payment allocation - book Bank Fee Amount Gh6769 (#6770) (cherry picked from commit 7fd422e) * payment allocation - book Bank Fee Amount after-CP fixes; also fixing some javadoc-errors Gh6769 (#6770) * Invisible croissant remote excel (#6806) * change H000 ComsAgreement from 901 to 903 * fixing strange build problem * Fix date when only one number used (#6809) * Fix date when only one number used * Formatting date fix * unrelated build problem fix (cherry picked from commit 2efff06) * Prettify code * Add debouncer * Tune up debouncer * removed debouncer as it is impacting the other widgets * Added unit test for the function and removed the export Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> * drop old function - avoid error where PG doesn't know which one to pick * drop old function - avoid error where PG doesn't know which one to pick * drop old function - avoid error where PG doesn't know which one to pick * #6779 2nd try - Now able to set 0 to invoice override field on catch weight billing candidates (#6815) * #6779 Now able to set 0 to invoice override field on catch weight billing candidates. * #6779 minor comment changes Co-authored-by: dragospodariu96 <58212697+dragospodariu96@users.noreply.github.com> * Add date formatting also in the Attributes dropdown (#6816) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Create 5560940_sys_gh6769_trls.sql #6769 * Create 5560941_sys_gh6769_trls.sql #6769 * #6817 Warehouse Temperature and Additional Information fields now in product translation window. (#6818) * Commission calculation without invoicing (#6813) Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> * build fix * unpost with p_force='Y', see comment * #6817 Translated Additional Information column and moved organisation last in grid view. (#6825) * Set locale from the local store (#6824) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Allow wholeTax-taxes also if the document has IsTaxIncluded=N (#6821) also minor improvements in ITaxBL, MInvoiceTax and IInvoiceCandidateHandlerBL * use LocalDate instead of java.util.Date (#6830) * Translation: `Transportation Order` / `Bill of Lading` (#6823) * introduce PostingError_Issue_ID to all accountable documents (#6820) * #6803 Can now generate delivery days for a specific tour version. (#6804) Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> * Set correctly the date according to locale if the date is updated with the string from BE in iso (#6831) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Extend Invoice reversal API to return affected ICs (#6828) * Update metasfresh-dist-serverRoot_jrebel-ssh_tunnel.launch * fix after merge * set guarantor-name as company name to the guarantor-address (#6826) Goal: have the guarantor on the printed invoice if guarantor != patient * fix BankStatementPaymentBL.linkSinglePayment (#6835) #6769 * Update InvoiceReferenceNosTest.java hotfix test * ProcurementFlatrateHandlerTests: convert to Junit5, avoid Mockit * refactor and introduced utils/locale.js to get/set current locale (#6837) * Fix the case where warehouse `Std Warehouse` (`M_Warehouse_ID = 540008`) does not exist. Part 1 (#6832) Co-authored-by: pvpurcarcosmin <pv.purcar.cosmin@gmail.com> * disable schedulers (#6840) #5816 * gh6769_4_uat (#6843) * hotfix BankSatementPaymentBL: create/match payment on TrxAmt instead of StmtAmt * hotfix avoid using the same payment when we have 2 identical bank statement lines #6769 * test window sandbox (#6836) * hotfix: when saving AD_Element(s), convert empty ColumnName to null; also did a small cleanup and removed not used code. * Create 5561270_sys_testWindowSandbox.sql #6845 * #6451 Take out secutiry filter * Master add metasfresh dev (#6805) Co-authored-by: TheBestPessimist <cristian@tbp.land> Co-authored-by: Teo Sarca <teo.sarca@gmail.com> Co-authored-by: Teo Sarca <t.sarca@metas-fresh.com> Co-authored-by: Teo Sarca <teo.sarca@metasfresh.com> Co-authored-by: metas-rc <ruxandra.craciunescu@metasfresh.com> Co-authored-by: Cristina Ghita <cristina.ghita@metasfresh.com> Co-authored-by: Cristina <cristinamghita@gmail.com> Co-authored-by: pvpurcarcosmin <50879041+pvpurcarcosmin@users.noreply.github.com> Co-authored-by: Julian Bischof <metas-jb@users.noreply.github.com> * #6451 Fix Functins to get the correct balance * #6451 FIx name * Attribute ID shall not be shown in Attribute Editor/ Attribute Button (#6849) * Create 5561110_sys_gh6819_AD_Issue_IssueCategory_mandatory.sql #6819 * Add sql query to cleanup all ASIs which have description = ASI_ID (#6855) * #6819 solve SQL error ERROR: column "issuecategory" contains null values * #6451 Transform account parameter to search field * #6860 rearranging_marketing_platform_view (#6861) * Fix linter error * Use locale utils where possible - update tests * another linter error Co-authored-by: Petrica Nanca <petrica_nanca@yahoo.com> Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> Co-authored-by: Ruxandra Craciunescu <ruxandra.craciunescu@metasfresh.com> Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> Co-authored-by: pvpurcarcosmin <50879041+pvpurcarcosmin@users.noreply.github.com> Co-authored-by: TheBestPessimist <cristian@tbp.land> Co-authored-by: Cristina Ghita <cristina.ghita@metasfresh.com> Co-authored-by: Tobias Schöneberg <metas-ts@users.noreply.github.com> Co-authored-by: pvpurcarcosmin <pv.purcar.cosmin@gmail.com> Co-authored-by: Teo Sarca <teo.sarca@metasfresh.com> Co-authored-by: dragospodariu96 <58212697+dragospodariu96@users.noreply.github.com> Co-authored-by: Cristina <cristinamghita@gmail.com> Co-authored-by: Teo Sarca <teo.sarca@gmail.com> Co-authored-by: Teo Sarca <t.sarca@metas-fresh.com> Co-authored-by: Julian Bischof <metas-jb@users.noreply.github.com> Co-authored-by: Norbert <metasnw@users.noreply.github.com>
petrican
added a commit
that referenced
this pull request
Jun 26, 2020
* Rewrite Table component (#6772) * #6706 Refactor QuickActions - use selector for actions - remove lots of unnecessary anonymous functions * #6706 Refactor DocumentList - remove anonymous functions - set refs properly * #6706 refactoring Table - remove anonymous functions in shortcuts * #6706 move DocumentList container to containers * #6706 progress on refactoring Table * #6706 start splitting Table component - into data and presentational layer * #6706 continue splitting Table to data/presentation - add some comments - remove unnecessary props * #6706 move `deleteRequest` to `api` * #6706 add action for collapsing rows * #6706 remove old `setActiveSort` * #6706 finishing touches on the Table component - remove what's unused - add comments and missing props - remove an unnecessary anonymous click handler fn in TableItem * #6706 WIP on collapsing rows * #6706 progress with collapsible rows - rename `windowType` to `windowId` in `getTableId` everywhere * #6706 cleanup * #6706 cleanup and rename props - remove what's not used anymore - rename `windowType` to `windowId` in main components - switch to redux data where possible * #6706 progress with refactoring - finish work on collapsible rows - more cleanup * #6706 update props/prop types * #6706 remove old AC's for selecting/deselecting - reuse action types - remove selection from DocList's lifecycle methods * #6706 ACs for updating data/selecting/deselecting - add data AC - add deselect AC - refactoring * #6706 cleanup table component * #6706 cleanup - remove unused code - add comments * #6706 add keyProperty param when selecting - cleanup of action creators - don't build collapsible arrays if not needed * #6706 delete table when filter changes - cleanup ViewActions * #6706 remove rowData denpendency from DocumentList - cleanup and comments too * #6706 fix fetching tab's data * #6706 cleanup and fix selections flow - * #6706 cleanup DocumentList container * #6706 suppress lint exception * #6706 remove more unused code * #6706 fix table reducer tests * #6706 update Table AC tests * #6706 updating rows in tab table - remove unused layout/data properties * #6706 fix error when unmounting DocumentList * #6706 handle ws row changes in tabs * #6706 add missing advanced edit event handler * #6706 cleanup Tab component * #6706 remove state completely from the TableContainer * #6706 cleanup * #6706 improvements to collapsing - fix selection when collapsing - don't build collapsible tree if not needed * #6706 properly create tables for modals * #6706 delete table on closing RawModal * #6706 remove getSizeClass from the parent - fix hiding included view on click outside * #6706 read view properly in Container * #6706 send correct props to SideList * #6706 fix initial collapsed rows * #6706 add AC for showing included view - move View actions to a separate file - cleanup ActionTypes * #6706 control included views with Redux actions * #6706 cleanup WindowHandler * #6706 make table row react to changes again * #6706 cleanup * Better error handling in tabs (#6789) * #6706 remove some unnecessary code, switch to PureComponents - anonymous functions - unused props * #6706 fix `Add New` modal * #6706 limit selection updates * #6706 fix keyboard navigation * #6706 fix deleting a row in tab * #6706 remove unused code from `WindowActions` * #6706 fixing tests * #6706 fix linter * #6706 fix MasterWindow tests * #6706 move ActionButton to PureComponent - rewrite event handlers and anonymous functions * #6706 limit unnecessary renders - small cleanup in WindowHandler * #6706 fix linter again * #6706 fixing tests * #6706 fix tests and change table focus logic * #6706 remove some unnecessary Tabs code * #6706 fix sfocusing rows when selected with key * unrelated build problem fix * #6706 linter error * #6706 update tests * #6706 small refactoring * #6706 add code comments * #6706 more comments * #6706 fixing jenkins tests Co-authored-by: dragospodariu96 <58212697+dragospodariu96@users.noreply.github.com> Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> * TableCell refactoring (#6844) * TableCell refactoring * Removed unused code * Reverting to == as it was intended like thats afais * Doc state * Added doc * Ditch entityEffective and use just the passed entity * Added some more doc and unit tests * Completed the unit tests Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Update with latest master (#6834) * rebase with master * fix tests Co-authored-by: Petrica Nanca <petrica_nanca@yahoo.com> * Fixing tests for tables & cleanup after merge with master (#6852) * #6706 remove unused props change conditions for showing spinner * #6706 split table component into two smaller entities remove unused code # Conflicts: # frontend/src/utils/tableHelpers.js * #6706 disconnect header from the store * #6706 fix table tests * fix linter error * rename Wrapper to TableWrapper * #6706 fix 404 when there is no data (#6858) * Merge master (#6865) * Add fixes for dates depending on the locale #6712 (#6715) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Add fixes for dates depending on the locale #6712 (#6715) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> (cherry picked from commit c388007) * #6615 comment out credit memo after partial request (#6728) * Gh6615 4 add process description (#6733) * Gh6615 5 rename migration file (#6736) * #6615 comment out credit memo after partial request #6615 * #6615 delete unneeded code and refactoring warning message #6615 * #6615 don't assume anything on this level. The user will make they needed changes. #6615 * #6615 update CreateCreditMemo process description #6615 * #6615 Allow the user to allocate as much as they want on a credit memo #6615 * #6615 Cleanup the code. * The old partial credit memo handling is no longer needed so we decided to drop it completely, not keep it for docu purposes. #6615 * #6615 update process description #6615 * #6615 rename script #6615 * Gh6743 uom conversion with round UP (#6744) * when converting quantities, round up * #6743 repair the tests to fit the new rounding mode #6743 Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> * #6615 null check in pay selection updater #6615 * #6718 Fix uomconvertdirect.sql and MD_Stock_From_HUs_V.sql (#6755) (cherry picked from commit 2259f58) * #6718 fix case of missing MD_Stock records * Window Distribution Order enhancements (#6752) * Window Distribution Order enhancements refs: #6713 * 6723 table tests (#6773) * Fix formatting in the config and fixed import #6723 * Reordered the structure for the fixtures #6732 * Test the props passed #6723 * Add test with store data #6723 * Remove debug line #6723 * Table status update check #6723 * Base TableCell tests #6723 * Skel for TableContextMenu #6723 * Removed comment from #6723 * Added eventsourcemock and settings in jest for the TableContextMenu #6723 * Test if TableContextMenu is rendering properly #6723 * More unit tests added to TableContextMenu #6723 * Add fixture for the EntryTable component #6723 * Added skel for the EntryTable tests #6723 * Small fix to ditch the warnings complaining about required fncts #6723 * Managed to do fixes to the mockup in order to render properly the component #6732 * Fix linter err * Added fixture for the TableFilter #6723 * Basic tests for rendering TestingFilter #6723 * Fixtures for the TableHeader #6723 * Small fixes in the TableItem #6723 * Add unit tests for the TableHeader #6723 * Prettier formatting #6723 * Fixtures for table pagination * Base test for TablePagination #6723 * Test active page #6723 * Pagination tests selection #6723 * TablePagination compressed tests #6723 * Added fixtures for the TableQuickInput #6723 * TableQuickInput basic rendering test #6723 * Removed debug Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * `Payment Allocation` action shall open also when Payments not available (#6776) * #6777 Shall refresh even if is single document (#6778) * #6777 Shall refresh even if is single document * minor: add comments Co-authored-by: Tobias Schöneberg <metas-ts@users.noreply.github.com> * #6777 Repair process refresh - invalidate documents (#6781) * moved to callout (#6748) #6745 * Show scrollbar when exceeds the visible area #6687 (#6775) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Update metasfresh-dist-serverRoot_jrebel.launch * #6785 don't spread `this.state` when setting state (#6786) * Master manual invoice (#6787) * Fix unit tests (#6788) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Better error handling in tabs (#6789) * #6713 Fixed minor details. (#6793) * #6794 Changed font size and unbolded it. (#6795) * gh6784_3_ic (#6792) * AllocationAmounts.toString() improvements (i.e. make it shorter) * fix PaymentsViewAllocateCommand.toPayableDocument + tests #6784 * #6779 Now sending 0 instead of null to frontend in the case we receive 0 for the qty to invoice override field. (#6780) * #6779 Now sending 0 instead of null to frontend in the case we receive 0 for the qty to invoice override field. * Set the null value when we have no number in the input Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Add fixes for dates depending on the locale #6712 (#6715) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> (cherry picked from commit c388007) * Fix accidental inactivation of not-IBAN bank accounts (#6799) * Fix accidental inactivation of not-IBAN bank accounts (#6799) (cherry picked from commit 58f0e4d) * Fix accidental inactivation of not-IBAN bank accounts (#6799) manually porting the changes from master commit 58f0e4d * Wrong Organisation set to HUs when doing Inventory or Material Receipt (#6783) Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> * set C_Invoice_Candidate.ApprovalForInvoicing=Y when enqueing for invoicing (#6768) #6767 * set C_Invoice_Candidate.ApprovalForInvoicing=Y when enqueing for invoicing (#6768) #6767 * Gh6769 (#6770) * payment allocation - book Bank Fee Amount Gh6769 (#6770) (cherry picked from commit 7fd422e) * payment allocation - book Bank Fee Amount after-CP fixes; also fixing some javadoc-errors Gh6769 (#6770) * Invisible croissant remote excel (#6806) * change H000 ComsAgreement from 901 to 903 * fixing strange build problem * Fix date when only one number used (#6809) * Fix date when only one number used * Formatting date fix * unrelated build problem fix (cherry picked from commit 2efff06) * Prettify code * Add debouncer * Tune up debouncer * removed debouncer as it is impacting the other widgets * Added unit test for the function and removed the export Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> * drop old function - avoid error where PG doesn't know which one to pick * drop old function - avoid error where PG doesn't know which one to pick * drop old function - avoid error where PG doesn't know which one to pick * #6779 2nd try - Now able to set 0 to invoice override field on catch weight billing candidates (#6815) * #6779 Now able to set 0 to invoice override field on catch weight billing candidates. * #6779 minor comment changes Co-authored-by: dragospodariu96 <58212697+dragospodariu96@users.noreply.github.com> * Add date formatting also in the Attributes dropdown (#6816) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Create 5560940_sys_gh6769_trls.sql #6769 * Create 5560941_sys_gh6769_trls.sql #6769 * #6817 Warehouse Temperature and Additional Information fields now in product translation window. (#6818) * Commission calculation without invoicing (#6813) Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> * build fix * unpost with p_force='Y', see comment * #6817 Translated Additional Information column and moved organisation last in grid view. (#6825) * Set locale from the local store (#6824) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Allow wholeTax-taxes also if the document has IsTaxIncluded=N (#6821) also minor improvements in ITaxBL, MInvoiceTax and IInvoiceCandidateHandlerBL * use LocalDate instead of java.util.Date (#6830) * Translation: `Transportation Order` / `Bill of Lading` (#6823) * introduce PostingError_Issue_ID to all accountable documents (#6820) * #6803 Can now generate delivery days for a specific tour version. (#6804) Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> * Set correctly the date according to locale if the date is updated with the string from BE in iso (#6831) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Extend Invoice reversal API to return affected ICs (#6828) * Update metasfresh-dist-serverRoot_jrebel-ssh_tunnel.launch * fix after merge * set guarantor-name as company name to the guarantor-address (#6826) Goal: have the guarantor on the printed invoice if guarantor != patient * fix BankStatementPaymentBL.linkSinglePayment (#6835) #6769 * Update InvoiceReferenceNosTest.java hotfix test * ProcurementFlatrateHandlerTests: convert to Junit5, avoid Mockit * refactor and introduced utils/locale.js to get/set current locale (#6837) * Fix the case where warehouse `Std Warehouse` (`M_Warehouse_ID = 540008`) does not exist. Part 1 (#6832) Co-authored-by: pvpurcarcosmin <pv.purcar.cosmin@gmail.com> * disable schedulers (#6840) #5816 * gh6769_4_uat (#6843) * hotfix BankSatementPaymentBL: create/match payment on TrxAmt instead of StmtAmt * hotfix avoid using the same payment when we have 2 identical bank statement lines #6769 * test window sandbox (#6836) * hotfix: when saving AD_Element(s), convert empty ColumnName to null; also did a small cleanup and removed not used code. * Create 5561270_sys_testWindowSandbox.sql #6845 * #6451 Take out secutiry filter * Master add metasfresh dev (#6805) Co-authored-by: TheBestPessimist <cristian@tbp.land> Co-authored-by: Teo Sarca <teo.sarca@gmail.com> Co-authored-by: Teo Sarca <t.sarca@metas-fresh.com> Co-authored-by: Teo Sarca <teo.sarca@metasfresh.com> Co-authored-by: metas-rc <ruxandra.craciunescu@metasfresh.com> Co-authored-by: Cristina Ghita <cristina.ghita@metasfresh.com> Co-authored-by: Cristina <cristinamghita@gmail.com> Co-authored-by: pvpurcarcosmin <50879041+pvpurcarcosmin@users.noreply.github.com> Co-authored-by: Julian Bischof <metas-jb@users.noreply.github.com> * #6451 Fix Functins to get the correct balance * #6451 FIx name * Attribute ID shall not be shown in Attribute Editor/ Attribute Button (#6849) * Create 5561110_sys_gh6819_AD_Issue_IssueCategory_mandatory.sql #6819 * Add sql query to cleanup all ASIs which have description = ASI_ID (#6855) * #6819 solve SQL error ERROR: column "issuecategory" contains null values * #6451 Transform account parameter to search field * #6860 rearranging_marketing_platform_view (#6861) * Fix linter error * Use locale utils where possible - update tests * another linter error Co-authored-by: Petrica Nanca <petrica_nanca@yahoo.com> Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> Co-authored-by: Ruxandra Craciunescu <ruxandra.craciunescu@metasfresh.com> Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> Co-authored-by: pvpurcarcosmin <50879041+pvpurcarcosmin@users.noreply.github.com> Co-authored-by: TheBestPessimist <cristian@tbp.land> Co-authored-by: Cristina Ghita <cristina.ghita@metasfresh.com> Co-authored-by: Tobias Schöneberg <metas-ts@users.noreply.github.com> Co-authored-by: pvpurcarcosmin <pv.purcar.cosmin@gmail.com> Co-authored-by: Teo Sarca <teo.sarca@metasfresh.com> Co-authored-by: dragospodariu96 <58212697+dragospodariu96@users.noreply.github.com> Co-authored-by: Cristina <cristinamghita@gmail.com> Co-authored-by: Teo Sarca <teo.sarca@gmail.com> Co-authored-by: Teo Sarca <t.sarca@metas-fresh.com> Co-authored-by: Julian Bischof <metas-jb@users.noreply.github.com> Co-authored-by: Norbert <metasnw@users.noreply.github.com> * #6706 tests for handling empty data (#6859) * Properly render dataEntries in tabs (#6877) * #6873 pass data to EntryTable * #6873 properly render dataEntries * #6873 update entryTable tests * #6873 simplify TableHeader tests * #6873 linter error after cleanup * #6873 more cleanup in the TableHeader test * Handle attributes in modal properly (#6878) * #6873 simplify spinner * #6873 move setting selectionAttribute to redux - use simplified spinner in DocumentList * #6873 small refactoring * Gh6866 MasterWidget (#6872) * Extract isNumberField function to an external util file * format dateParse arr from the constants prevent DRY * Removed the logic from componentDidMount that was causing extra re-rendering by setting the state * Added back the original doc * Add unit tests for the isNumberField fnct * Ditch the UNSAFE_componentWillReceiveProp * handlePatch refactoring * More refactoring within MasterWidget move validatePrecision outside * Add unit tests for formatValueByWidgetType * Add unit tests for the validatePrecision * Import only the necessary actions * Removed desc on main render function * Changed variable name * Added extra safety checks Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Get size of the table from table prosp (#6880) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Fix bugs after refactoring (#6881) * #6873 fix updating document data on change * #6873 remove anonymous ref fns from RawWidget * #6873 simplify indicator - fix bug when `classnames` didn't react to changes * #6783 refactor showing indicator - move components to PureComponents - fix overwriting valid/saveStatus * Revert "Gh6866 MasterWidget (#6872)" This reverts commit 20cc8d5. MasterWidget was not properly reacting to changes. * #6873 fix condition for showing indicator * Fix linter error Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Fix bug in the MasterWidget helper fnct (#6882) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Fix switch pages after edit (#6891) Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * Fix indicator in modal * Refactoring selections and TableItems component (#6895) * - import `getSizeClass` directly in `TableCell` * #6854 TableItem initial refactoring * #6873 fix changing selection with multiple rows selected - remove some old code - add missing props * #6873 rewrite SubHeader's selections - use redux as data source * #6854 add removed helper fn back * #6873 rewrite selections for Actions - use redux as data source * #6873 rewrite selections for Modal - and small refactoring along the way * #6873 ditch old selections completely * #6873 small cleanup along the way * Fix linter error * #6873 update selections again * #6873 fix props, other small refactorings * - get rid of `editedCells` * #6854 remove unused code * #6854 add doc * Add back the test that renders with store data * Add extra safety check in Table and some unit tests * #6854 check if rows have length before selecting * #6854 cleanup TableItem - move some logic to utils - add code comments - other small changes * #6873 fix rendering table actions buttons * #6854 support storing change of a row property * #6854 improve comments * #6783 send same props to modals as in master * #6783 fix error when sorting * Fix linter error Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> * fix failing frontend tests * #6854 rewrite code for removing rows Co-authored-by: dragospodariu96 <58212697+dragospodariu96@users.noreply.github.com> Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> Co-authored-by: Petrica Nanca <petrica_nanca@yahoo.com> Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> Co-authored-by: Ruxandra Craciunescu <ruxandra.craciunescu@metasfresh.com> Co-authored-by: pvpurcarcosmin <50879041+pvpurcarcosmin@users.noreply.github.com> Co-authored-by: TheBestPessimist <cristian@tbp.land> Co-authored-by: Cristina Ghita <cristina.ghita@metasfresh.com> Co-authored-by: Tobias Schöneberg <metas-ts@users.noreply.github.com> Co-authored-by: pvpurcarcosmin <pv.purcar.cosmin@gmail.com> Co-authored-by: Teo Sarca <teo.sarca@metasfresh.com> Co-authored-by: Cristina <cristinamghita@gmail.com> Co-authored-by: Teo Sarca <teo.sarca@gmail.com> Co-authored-by: Teo Sarca <t.sarca@metas-fresh.com> Co-authored-by: Julian Bischof <metas-jb@users.noreply.github.com> Co-authored-by: Norbert <metasnw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.