Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packing Instruction selectable that does not fit to Businesspartner #6870

Merged
merged 9 commits into from Jun 18, 2020
Merged

Packing Instruction selectable that does not fit to Businesspartner #6870

merged 9 commits into from Jun 18, 2020

Conversation

TheBestPessimist
Copy link
Contributor

@TheBestPessimist
Add filtering by PLV to IHUPIItemProductQuery
08d3e50 
#6868
@TheBestPessimist
Fix warnings, add nullability info
7d2fce1 
#6868
@TheBestPessimist
Fix typo
a1f3310 
#6868
@TheBestPessimist
Remove Validation Rule `M_HU_PI_Item_Product_For_Org_and_Product_and_…
f1b31f7 
…DateOrdered`

#6868
@TheBestPessimist
Use Validation Rule `M_HU_PI_Item_Product_For_Org_and_Product_and_Dat…
58ed57d 
…ePromised` when getting the list of Packing Instructions in C_OrderLine quick input

#6868
@TheBestPessimist
Midwork
edd5c89 
#6868
@TheBestPessimist
Remove C_Order.MProductChange callout, and the unused java code.
5ff2cf2 
That callout can be removed as it was only used in swing.

#6868
@TheBestPessimist
Cleanup
25e1038 
#6868
@TheBestPessimist
Add fix for quick input for the case: Purchase Orders default value s…
2b7d9ea 
…earch

In the case of Purchase Orders, only the Packing Instructions which are set on Purchase Product Prices are used.

#6868
metas-ts
metas-ts approved these changes Jun 18, 2020
View reviewed changes
.../de.metas.handlingunits.base/src/main/java/de/metas/handlingunits/IHUPIItemProductQuery.java
@Nullable
PriceListVersionId getPriceListVersionId();

void setDate(@Nullable ZonedDateTime date);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: rename to setValidAtDate .. i think it's clearer that way

@metas-ts metas-ts merged commit 646e813 into master Jun 18, 2020
@metas-ts metas-ts deleted the gh6868-C_Order_PI branch June 18, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metas-ts metas-ts metas-ts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheBestPessimist @metas-ts