Servicefees per Provider Customer #6910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metas-ts
reviewed
Jun 26, 2020
There was a problem hiding this comment.
I took an intermediate look, looks ok so far
You know, opinions als like a-holes, here is mine: i think you should do less stream-processing and instead more for-looping. because it's easier to work with in the debugger. but that might be just a matter of taste on my part.
teosarca
reviewed
Jun 26, 2020
.../de/metas/invoice/invoiceProcessingServiceCompany/InvoiceProcessingServiceCompanyConfig.java
Outdated
Show resolved
Hide resolved
teosarca
reviewed
Jun 26, 2020
...invoice/invoiceProcessingServiceCompany/InvoiceProcessingServiceCompanyConfigRepository.java
Outdated
Show resolved
Hide resolved
TheBestPessimist
force-pushed
the
gh6904-servicefee-invisible-croissant-uat
branch
from
5daad27
to
5f8d8f3
Compare
metas-ts
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6904