Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI in create dataset with Database #1015

Closed
paigechoi opened this issue Dec 5, 2018 · 1 comment
Closed

Fix UI in create dataset with Database #1015

paigechoi opened this issue Dec 5, 2018 · 1 comment
Assignees
@paigechoi @sang-hee-lee @joohokim1
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone
3.1.0

Comments

@paigechoi
Copy link
Contributor

paigechoi commented Dec 5, 2018 •
edited
Loading

Describe the bug
Add Security component in dataset create popup (database)

To Reproduce
Steps to reproduce the behavior:
Dataset tab -> create db dataset -> see error

Expected behavior
image

  1. Database type oracle is removed
  2. Security component is added

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@paigechoi paigechoi added the @dataprep Component Name : Data preparation label Dec 5, 2018
paigechoi added a commit that referenced this issue Dec 5, 2018
@paigechoi
#1015 fix input disable issue when connection security is connect wit…
c54cf97 
…h id and password
@paigechoi paigechoi mentioned this issue Dec 5, 2018
Merged
9 tasks
@paigechoi paigechoi added this to the 3.1.0 milestone Dec 5, 2018
paigechoi added a commit that referenced this issue Dec 5, 2018
@paigechoi
#1015 add querystmt when creating datset (table type), only manual au…
fc8da0d 
…thentication can be used to make dataset
@paigechoi paigechoi changed the title Input is disabled when connection Security is "Connect with ID and password" Fix UI in create dataset with Database Dec 5, 2018
paigechoi added a commit that referenced this issue Dec 6, 2018
@paigechoi
#1015 fix input disable issue when connection security is connect wit…
09bb74e 
…h id and password
paigechoi added a commit that referenced this issue Dec 6, 2018
@paigechoi
#1015 add querystmt when creating datset (table type), only manual au…
8d58986 
…thentication can be used to make dataset
@paigechoi
Copy link
Contributor Author

@joohokim1
Originally this issue was created to provide user with security options. (See screenshot)
In datasource user can use connections (with any security setting) to make datasource.
However in dataprep, user can only use connection with Always connect
Dataprep Server API must be fixed to support Connect by user account and connect with Id and password security type connections.

@joohokim1 joohokim1 added the bug Something isn't working label Dec 6, 2018
alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@paigechoi @alchan-lee
#1015 fix input disable issue when connection security is connect wit…
ba880b9 
…h id and password
alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@paigechoi @alchan-lee
#1015 add querystmt when creating datset (table type), only manual au…
a967f53 
…thentication can be used to make dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paigechoi paigechoi

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
3 participants
@paigechoi @sang-hee-lee @joohokim1