Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp type column error when deleting #1019

Closed
paigechoi opened this issue Dec 6, 2018 · 3 comments
Closed

Timestamp type column error when deleting #1019

paigechoi opened this issue Dec 6, 2018 · 3 comments
Assignees
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone

Comments

@paigechoi
Copy link
Contributor

Describe the bug
When column type is TIMESTAMP and timestamp format does't have year(YYYY)
delete and keep fails in context menu.

To Reproduce
Steps to reproduce the behavior:
Dataflow main grid -> Add Setformat to timestamp type column. Format is MM-dd -> click histogram (column that you just added setformat to) -> context menu -> delete -> see error

Expected behavior
Selected row must be deleted.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@paigechoi paigechoi added the @dataprep Component Name : Data preparation label Dec 6, 2018
@joohokim1 joohokim1 added the bug Something isn't working label Dec 7, 2018
@joohokim1 joohokim1 assigned mh0203 and unassigned paigechoi and sang-hee-lee Dec 7, 2018
@joohokim1 joohokim1 added this to the 3.2.0 milestone Dec 7, 2018
@joohokim1
Copy link
Contributor

It seems like better having the server deliver the timestamp format string to be used in conditional expressions.
@ mh0203 will work on it.

서버에서 조건문에 사용할 timestamp format string을 함께 내리는 것이 좋겠습니다.
@mh0203 님께서 작업하실 예정입니다.

@mh0203
Copy link
Contributor

mh0203 commented Dec 13, 2018

This request is resolved as follows

  1. Histogram gives labels and real timestamp value both.
  2. Add a new function to determine if a given time value is within range.

@mh0203
Copy link
Contributor

mh0203 commented Dec 13, 2018

screen shot 2018-12-13 at 4 38 39 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Development

No branches or pull requests

4 participants