New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for adding basemap in mapview via configuration #1064

Closed
kyungtaak opened this Issue Dec 10, 2018 · 3 comments

Comments

@kyungtaak
Copy link
Contributor

kyungtaak commented Dec 10, 2018

Is your feature request related to a problem? Please describe.
Currently, we only support OpenStreetMap as a base map within MapView functionality.
Some users want to select the base map they need through configuration.

Describe the solution you'd like
We can set information about the base map in the application configuration and select it from the MapView widget.

Describe alternatives you've considered
(N/A)

Additional context
Properties related basemap (application.yaml)

polaris
    widget:
        mapView:
          defaultBaseMap: Light  # Default base map name
          overrideBaseMap: false # Whether to use only the custom base map
          baseMaps:              # info. of custom base map
            -
              name: map1
              url: https://map.test.com/1
            -
              name: map2
              url: https://map.test.com/2
@kyungtaak

This comment has been minimized.

Copy link
Contributor Author

kyungtaak commented Jan 7, 2019

@eltriny 현재 사용하고 있는 basemap 이름과 url 정보를 알려주실수 있나요?

@eltriny

This comment has been minimized.

Copy link
Contributor

eltriny commented Jan 10, 2019

@kyungtaak
Light (Metatron Default): http://{1-4}.basemaps.cartocdn.com/light_all/{z}/{x}/{y}.png
Dark: http://{1-4}.basemaps.cartocdn.com/dark_all/{z}/{x}/{y}.png
Colored: OpenLayers 기본제공

@kyungtaak

This comment has been minimized.

Copy link
Contributor Author

kyungtaak commented Jan 11, 2019

@dave-taeho @eltriny basemap 관련 설정 정보입니다. mapView 위젯 로드시 호출이 필요합니다. (f#1064-adding_basemap_in_mapview)

  • API : (GET) /api/widgets/properties/mapview
  • Response
{
    "defaultBaseMap": "Light",   // 기본 BaseMap 이름
    "overrideBaseMap": false,    // true 인경우 embed 된 basemap 을 무시하고 baseMaps 의 항목으로 대체
    "baseMaps": [                        // Custom Base Map 목록
        {
            "name": "mapmap",
            "url": "https://map.test.com/....."
        }
    ]
}

eltriny pushed a commit that referenced this issue Jan 16, 2019

alchan-lee added a commit that referenced this issue Jan 17, 2019

#1064 Support for adding basemap in mapview via configuration (#1265)
* #1064 add properties about basemap in mapview and api to get properties

* #1064 Added feature to use in map view when property value exists

@alchan-lee alchan-lee closed this Jan 17, 2019

eltriny pushed a commit that referenced this issue Jan 17, 2019

@eltriny eltriny referenced this issue Jan 17, 2019

Merged

#1064 fix error when creating map chart #1273

1 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment