Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download file or staging db snapshots as JSON files #1086

Closed
joohokim1 opened this issue Dec 13, 2018 · 1 comment
Closed

Download file or staging db snapshots as JSON files #1086

joohokim1 opened this issue Dec 13, 2018 · 1 comment
Assignees
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Milestone

Comments

@joohokim1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I would like to be able to download the contents of a snapshot as a JSON file.

Snapshot의 내용을 JSON 파일로 받을 수 있으면 좋겠습니다.

Describe the solution you'd like
Now the JSON file snapshot has been implemented (#1074), so I would like to be able to download all the snapshot contents as a JSON file. In addition to FILE snapshots, I also want to make STAGING_DB snapshots downloadable as a CSV or JSON file.

이제 JSON file snapshot이 구현되었기 때문에 (#1074) snapshot 내용을 JSON 파일로 download 받을 수 있으면 좋겠습니다. FILE snapshot 뿐만아니라, STAGING_DB 도 CSV 또는 JSON 파일로 받을 수 있게 하면 좋겠습니다.

Additional context
In fact, you can download JSON snapshots now (as a result of #1074). Although the name is .csv but, the contents are JSON. We are going to close snapshot downloading matters including STAGING_DB types in this issue.

사실 현재 (#1074 의 결과로) JSON snapshot에 대해서도 download가 가능합니다. 비록 파일 이름은 .csv로 내려오지만, 그 내용은 JSON입니다. 본 이슈는 FILE 뿐만아니라 STAGING_DB snapshot도 아울러서 snapshot download 기능을 마감하고자 하는 이슈입니다.

@joohokim1 joohokim1 added enhancement Request Change and Feature Enhancement @dataprep Component Name : Data preparation labels Dec 13, 2018
@joohokim1 joohokim1 added this to the 3.2.0 milestone Dec 13, 2018
@joohokim1 joohokim1 self-assigned this Dec 13, 2018
@mh0203 mh0203 self-assigned this Dec 14, 2018
@mh0203
Copy link
Contributor

mh0203 commented Dec 17, 2018

UI work required.
For hive(staging db) type snapshot...

  1. Add a JSON file download button in snapshot detail screen.
  2. Add the "fileType" request param for the snapshot download api.
    ex) /{ssId}/download?fileType=json or /{ssId}/download?fileType=csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants