Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show warnings when rule has "aggregate" #1184

Closed
sang-hee-lee opened this issue Jan 4, 2019 · 0 comments
Closed

Show warnings when rule has "aggregate" #1184

sang-hee-lee opened this issue Jan 4, 2019 · 0 comments
Assignees
@paigechoi @sang-hee-lee @joohokim1
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Milestone
3.2.0

Comments

@sang-hee-lee
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Warnings that apply aggregate rules

Describe the solution you'd like
Alert message when applying an aggregation rule and when applying an aggregation rule

Describe alternatives you've considered

Additional context
@sang-hee-lee sang-hee-lee added the @dataprep Component Name : Data preparation label Jan 4, 2019
@sang-hee-lee sang-hee-lee added this to the 3.2.0 milestone Jan 7, 2019
@paigechoi paigechoi self-assigned this Jan 7, 2019
@paigechoi paigechoi changed the title Warnings that apply aggregate rules Show warnings when rule includes aggregate Jan 7, 2019
@paigechoi paigechoi changed the title Show warnings when rule includes aggregate Show warnings when rule has "aggregate" Jan 7, 2019
@joohokim1 joohokim1 added the enhancement Request Change and Feature Enhancement label Jan 7, 2019
paigechoi added a commit that referenced this issue Jan 7, 2019
@paigechoi
#1184 Show warnings regarding aggregate
7f19f9e 
- show warning next to grid search box when rule contains aggregate rule
- show warning in builder when aggregate is selected
paigechoi added a commit that referenced this issue Jan 7, 2019
@paigechoi
#1184 Add translation
388979c
@paigechoi paigechoi mentioned this issue Jan 7, 2019
Merged
9 tasks
paigechoi added a commit that referenced this issue Jan 9, 2019
@paigechoi
#1184 warning design is changed (aggregation)
738a4a3
paigechoi added a commit that referenced this issue Jan 10, 2019
@paigechoi
#1184 Fix search box x button display option
d3187ee
paigechoi added a commit that referenced this issue Jan 10, 2019
@paigechoi
#1184 Fix css issue regarding warning message (aggregate)
72ef783
paigechoi added a commit that referenced this issue Jan 16, 2019
@paigechoi
#1184 Fix aggregation warning design
c002551
joohokim1 pushed a commit that referenced this issue Jan 16, 2019
@paigechoi @joohokim1
F#1184 show aggregation warning (#1201)
67edfb3 
* #1184 Show warnings regarding aggregate
- show warning next to grid search box when rule contains aggregate rule
- show warning in builder when aggregate is selected

* #1184 Add translation

* #1184 warning design is changed (aggregation)

* #1184 Fix search box `x` button display option

* #1184 Fix css issue regarding warning message (aggregate)

* #1184 Fix aggregation warning design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paigechoi paigechoi

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
3 participants
@paigechoi @sang-hee-lee @joohokim1