Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When joining the data source of the dashboard creation, detailed error history is displayed in the toast popup. #1231

Closed
minjung-cho opened this issue Jan 10, 2019 · 1 comment
Closed

When joining the data source of the dashboard creation, detailed error history is displayed in the toast popup. #1231

minjung-cho opened this issue Jan 10, 2019 · 1 comment
Assignees
@kyungtaak @eltriny @paigechoi @alchan-lee
Labels
bug Something isn't working @dashboard Component Name : Dashboard / Chart
Milestone
3.3.0

Comments

@minjung-cho
Copy link

minjung-cho commented Jan 10, 2019 •
edited
Loading

Describe the bug
데이터소스를 조인 할 때, 전체 화면을 덮을 만큼 긴 에러 내역이 토스트 팝업에 나오고 있습니다.

To Reproduce

  1. Go to the dashboard creation
  2. Add datasource 'jointest-1'
  3. Go to 'join datasource' popup
    2019-01-10 2 43 31
  4. Select datasource 'jointest-2'
  5. See error
    2019-01-10 1 38 50
  6. Add any joinkey
  7. See error
    2019-01-10 1 40 05

Expected behavior
일반 사용자가 알수 없는 에러 내역은 토스트 팝업에 직접 보여주지 않습니다. 필요 시 관리자화면에서 'detail 보기' 버튼을 제공하여 상세 내역을 확인하도록 하고 있지만, METATRON-136에서 정의한 바에 따르면 아래와 같은 토스트 팝업이 떠야 합니다.
2019-01-10 2 39 45

Desktop

  • OS: MacOS
  • Browser : chrome
  • Version : christmas-2nd

Additional context
토스트 정책 : METATRON-136
@minjung-cho
Copy link
Author

minjung-cho commented Jan 10, 2019 •
edited
Loading

@kyungtaak @AnnieHwang
이슈는 UI 오류 내용을 적긴했습니다만, 현재 문제가 없어 보이는 두개의 데이터소스 조인 시 에러나 나서 조인을 완료할 수 없습니다. 확인 부탁드립니다.

추가로 #380 과 같이 컬럼 유사도를 체크하여 추천키를 제공해 주는 것이 가능하다면 조금더 사용성이 개선될것 같습니다. 검토해 주시면 관련 UI 팔로업 하겠습니다

@kyungtaak kyungtaak added @dashboard Component Name : Dashboard / Chart bug Something isn't working labels Feb 24, 2019
@kyungtaak kyungtaak added this to the 3.2.0 milestone Feb 24, 2019
@kyungtaak kyungtaak modified the milestones: 3.2.0, 3.3.0 Apr 8, 2019
paigechoi added a commit that referenced this issue May 9, 2019
@paigechoi
#1231 Show proper error msg when similarity API fails
9d9133d
paigechoi added a commit that referenced this issue May 10, 2019
@paigechoi
#1231 Fix alert error - alert pops up as soon as popup is opened
c3ab89b 
- update css for join popup
paigechoi added a commit that referenced this issue May 10, 2019
@paigechoi
#1231 Fix long txt css in join key
6e10d81
@paigechoi paigechoi mentioned this issue May 10, 2019
Merged
7 tasks
paigechoi added a commit that referenced this issue May 14, 2019
@paigechoi
#1231 Use clickable alert in join popup
c309241
paigechoi added a commit that referenced this issue May 14, 2019
@paigechoi
#1231 Change error msg
53379b6
kyungtaak pushed a commit that referenced this issue May 15, 2019
@paigechoi @kyungtaak
#1231 fix alert message in join popup
e0350b0 
* #1231 Show proper error msg when similarity API fails

* #1231 Fix alert error - alert pops up as soon as popup is opened
- update css for join popup

* #1231 Fix long txt css in join key

* #1231 Use clickable alert in join popup

* #1231 Change error msg
@AnnieHwang AnnieHwang mentioned this issue May 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyungtaak kyungtaak

@eltriny eltriny

@paigechoi paigechoi

@alchan-lee alchan-lee

Labels
bug Something isn't working @dashboard Component Name : Dashboard / Chart
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
5 participants
@kyungtaak @eltriny @minjung-cho @paigechoi @alchan-lee