Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply new suggestion to Window, aggregate, pivot. #1289

Closed
nowone123 opened this issue Jan 21, 2019 · 4 comments
Closed

Apply new suggestion to Window, aggregate, pivot. #1289

nowone123 opened this issue Jan 21, 2019 · 4 comments
Assignees
@sang-hee-lee @nowone123 @joohokim1
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Milestone
3.2.0

Comments

@nowone123
Copy link
Contributor

nowone123 commented Jan 21, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
apply new autocomplete function.

Describe the solution you'd like

  • window, aggregate, pivot of rules.
  • multiple input box.

Describe alternatives you've considered
(N/A)

Additional context
(N/A)
@nowone123 nowone123 added the @dataprep Component Name : Data preparation label Jan 21, 2019
@nowone123 nowone123 added this to the 3.2.0 milestone Jan 21, 2019
@nowone123
Copy link
Contributor Author

nowone123 commented Jan 22, 2019 •
edited
Loading

@joohokim1
aggregate 및 pivot Rule에서 Column Name backtick으로 감싸면 에러 가 발행합니다.
서버에서 backtick 관련 처리가 필요합니다.

@joohokim1
Copy link
Contributor

@nowone123
알겠습니다. 작업 후 알려드리겠습니다.

@joohokim1 joohokim1 added the enhancement Request Change and Feature Enhancement label Jan 22, 2019
nowone123 added a commit that referenced this issue Jan 22, 2019
@nowone123
#1289 send backtick to server in aggregate, pivot
15fbbe2
nowone123 added a commit that referenced this issue Jan 22, 2019
@nowone123
#1289 remove single quotation mark in aggregate, pivot, window.
fc598b6
@nowone123 nowone123 self-assigned this Jan 23, 2019
joohokim1 added a commit that referenced this issue Jan 23, 2019
@joohokim1
#1289 handle aggregation expressions as expression structures not lit…
a3129ca 
…erals
@joohokim1 joohokim1 assigned sang-hee-lee and unassigned joohokim1 Jan 23, 2019
@joohokim1
Copy link
Contributor

@nowone123
We now have the server handle aggregate, pivot, and window expressions as expression structures.
As a note, we used to use a literal to process the expressions through a string match.

이제 서버에서 aggregate, pivot, window의 수식을 expression 구조체로 처리하도록 했습니다.
참고로, 기존에는 literal로 받아서, string match를 통해 수식 계산을 수행했었습니다.

@joohokim1 joohokim1 self-assigned this Jan 23, 2019
@nowone123 nowone123 mentioned this issue Jan 30, 2019
Merged
9 tasks
joohokim1 pushed a commit that referenced this issue Jan 30, 2019
@nowone123 @joohokim1
F#1289 new suggestion window aggregate pivot (#1336)
6436c76 
* #1289 send backtick  to server in aggregate, pivot

* #1289 remove single quotation mark in aggregate, pivot, window.

* #1289 handle aggregation expressions as expression structures not literals

* #1298 applied new suggestion.
ninezero90hy pushed a commit that referenced this issue Jan 30, 2019
@nowone123 @ninezero90hy
F#1289 new suggestion window aggregate pivot (#1336)
4a7b85d 
* #1289 send backtick  to server in aggregate, pivot

* #1289 remove single quotation mark in aggregate, pivot, window.

* #1289 handle aggregation expressions as expression structures not literals

* #1298 applied new suggestion.
eltriny pushed a commit that referenced this issue Jan 30, 2019
@nowone123
F#1289 new suggestion window aggregate pivot (#1336)
20884ed 
* #1289 send backtick  to server in aggregate, pivot

* #1289 remove single quotation mark in aggregate, pivot, window.

* #1289 handle aggregation expressions as expression structures not literals

* #1298 applied new suggestion.
@joohokim1
Copy link
Contributor

2nd integrated test passed.

@sang-hee-lee sang-hee-lee mentioned this issue Feb 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sang-hee-lee sang-hee-lee

@nowone123 nowone123

@joohokim1 joohokim1

Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
3 participants
@sang-hee-lee @nowone123 @joohokim1