Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify file type snapshot information #1296

Closed
paigechoi opened this issue Jan 22, 2019 · 2 comments
Closed

Modify file type snapshot information #1296

paigechoi opened this issue Jan 22, 2019 · 2 comments
Assignees
@paigechoi @sang-hee-lee @joohokim1
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone
3.2.0

Comments

@paigechoi
Copy link
Contributor

paigechoi commented Jan 22, 2019 •
edited
Loading

Describe the bug
Some detailed information is missing in snapshot detail and list

To Reproduce
Steps to reproduce the behavior:

  1. Go to snapshot detail -> check snapshot type
    image

2 . Show file uri (only when snapshot type is file)

Expected behavior
1 . Snapshot type should be FILE(CSV) or FILE(JSON)

2 . Snapshot file uri should be visible
image

3 . Rows and column should be on the separate line
image

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
@paigechoi paigechoi added bug Something isn't working @dataprep Component Name : Data preparation labels Jan 22, 2019
paigechoi added a commit that referenced this issue Jan 22, 2019
@paigechoi
#1296 Add file type in snapshot detail
11235bb
paigechoi added a commit that referenced this issue Jan 22, 2019
@paigechoi
#1296 Add tooltip to long Created column in snapshot list
60abe0b
@paigechoi paigechoi mentioned this issue Jan 24, 2019
Closed
paigechoi added a commit that referenced this issue Jan 24, 2019
@paigechoi
#1296 Add file type in snapshot list
35d298b
@paigechoi paigechoi changed the title Show snapshot type (csv, json) in snapshot detail Modify file type snapshot information Jan 24, 2019
paigechoi added a commit that referenced this issue Jan 24, 2019
@paigechoi
#1296 Add file uri info in snapshot detail popup, update language
1c70892
@paigechoi paigechoi mentioned this issue Jan 28, 2019
Merged
9 tasks
paigechoi added a commit that referenced this issue Jan 28, 2019
@paigechoi
#1296 Separate rows and column into different line
d0053c8
paigechoi added a commit that referenced this issue Jan 28, 2019
@paigechoi
#1296 use ... when uri is longer than 2 lines
cb7ae04
@joohokim1 joohokim1 added this to the 3.2.0 milestone Jan 28, 2019
joohokim1 pushed a commit that referenced this issue Jan 29, 2019
@paigechoi @joohokim1
F#1296 Fix information in snapshot detail (#1323)
d44aaae 
* #1296 Add file type in snapshot detail

* #1296 Add tooltip to long Created column in snapshot list

* #1296 Add file type in snapshot list

* #1296 Add file uri info in snapshot detail popup, update language

* #1296 Separate rows and column into different line

* #1296 use ... when uri is longer than 2 lines
@paigechoi
Copy link
Contributor Author

paigechoi commented Jan 29, 2019 •
edited
Loading

storedUri LABEL (confirmed by @ecoloy & @joohokim1 )
Dataset detail -> URI
Snapshot detail -> FILE URI

ninezero90hy pushed a commit that referenced this issue Jan 30, 2019
@paigechoi @ninezero90hy
F#1296 Fix information in snapshot detail (#1323)
fa13835 
* #1296 Add file type in snapshot detail

* #1296 Add tooltip to long Created column in snapshot list

* #1296 Add file type in snapshot list

* #1296 Add file uri info in snapshot detail popup, update language

* #1296 Separate rows and column into different line

* #1296 use ... when uri is longer than 2 lines
paigechoi added a commit that referenced this issue Jan 31, 2019
@paigechoi
#1296 Show tooltip when snapshot file uri is shortened
2eefdcd
@paigechoi paigechoi mentioned this issue Jan 31, 2019
Merged
9 tasks
joohokim1 pushed a commit that referenced this issue Jan 31, 2019
@paigechoi @joohokim1
#1296 Show tooltip when snapshot file uri is shortened (#1348)
f1e433b
@joohokim1
Copy link
Contributor

2nd integrated test passed.

kyungtaak added a commit that referenced this issue Feb 1, 2019
@kyungtaak
#1363 3.2.0 rc1 Release
6a8176d 
* #1296 Show tooltip when snapshot file uri is shortened (#1348)

* #199 fix error input component (#1353)

* #199 change branch

* #199 remove input component in dashboard creation

* Fix range slider on map chart (#1351)

* #1057 fix error in datasource creation stage

* #1057 fix message in criterion filter

* #1057 fix database source create error

* #1057 fix file datasource error

* #1057 add default format in data source column detail used change physical type

* #1193 add timezone to dimension of timestamp type in pivot

* #1193 add timezone in pivot

* #1193 add timezone in shelf

* #1193 add timezone to timestamp type field

* #1355 fix undefined config data in interval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paigechoi paigechoi

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
3 participants
@paigechoi @sang-hee-lee @joohokim1