Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot see suggestion if there're many target expressions #1379

Closed
joohokim1 opened this issue Feb 1, 2019 · 1 comment
Closed

Cannot see suggestion if there're many target expressions #1379

joohokim1 opened this issue Feb 1, 2019 · 1 comment
Assignees
@paigechoi @sang-hee-lee @joohokim1
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone
3.2.0

Comments

@joohokim1
Copy link
Contributor

Describe the bug
When the expression list is too long (aggregate, pivot, window rule), The suggesting pop-up goes below the bottom edge.

To Reproduce
Steps to reproduce the behavior:

  1. Import & wrangle s5k_1.csv.txt
  2. Edit rules
  3. Select aggregate
  4. Put sum(column1) many times.
  5. You'll see the suggestion goes down too much.

Expected behavior
The suggestion should be shown above the rule input area.
It might be better to make this behavior the default, but I'm not convinced.

자동완성 창이 룰 입력 영역 위로 나와야합니다.
어쩌면 처음부터 자동완성 창이 위로 나오는 것이 좋을지도 모르겠습니다.

Screenshots
2019-01-30 11 52 11

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version: 68.0.3440.106
@joohokim1 joohokim1 added bug Something isn't working @dataprep Component Name : Data preparation labels Feb 1, 2019
@joohokim1 joohokim1 added this to the 3.2.0 milestone Feb 1, 2019
@joohokim1
Copy link
Contributor Author

@AnnieHwang

자동 완성 창이 처음부터 위로 나오는 것이 좋을지, 아니면 꼭 필요할 때에만 위로 나오는 것이 좋을지 조언 부탁드립니다.

@joohokim1 joohokim1 changed the title Cannot see suggestion if target expressions are too many Cannot see suggestion if there're many target expressions Feb 1, 2019
@paigechoi paigechoi self-assigned this Feb 28, 2019
paigechoi added a commit that referenced this issue Mar 12, 2019
@paigechoi
#1379 Trigger dropdown boxes above elements in single dropdown rules(…
e63a000 
…keep, delete, derive etc)
paigechoi added a commit that referenced this issue Mar 18, 2019
@paigechoi
#1379 Fix css error for multiple inputs when dropdown direction is up…
378dcd5 
… (window, aggregate, pivot)
paigechoi added a commit that referenced this issue Mar 18, 2019
@paigechoi
#1379 Use broadcaster when selectbox is closed (when command is not w…
7c96596 
…indow & aggr)
@paigechoi paigechoi mentioned this issue Mar 18, 2019
Merged
9 tasks
kaypark-skt pushed a commit that referenced this issue Mar 18, 2019
@paigechoi @kaypark-skt
#1379 fix suggestion layer direction (#1677)
565cac6 
* #1379 Trigger dropdown boxes above elements in single dropdown rules(keep, delete, derive etc)

* #1379 Fix css error for multiple inputs when dropdown direction is up  (window, aggregate, pivot)

* #1379 Use broadcaster when selectbox is closed (when command is not window & aggr)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paigechoi paigechoi

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
4 participants
@paigechoi @sang-hee-lee @joohokim1 @kaypark-skt