Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name input in dataprep (dataset/snapshot) #1532

Closed
paigechoi opened this issue Feb 27, 2019 · 1 comment
Closed

Fix name input in dataprep (dataset/snapshot) #1532

paigechoi opened this issue Feb 27, 2019 · 1 comment
Assignees
@paigechoi @sang-hee-lee @joohokim1 @kaypark-skt
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone
3.2.0

Comments

@paigechoi
Copy link
Contributor

paigechoi commented Feb 27, 2019 •
edited
Loading

Describe the bug

  1. When shift key and enter key is used, new line can be included in dataset/snapshot name

To Reproduce
Steps to reproduce the behavior:

  1. Go to dataflow detail => click one dataset -> click edit dataset name in the right panel -> press enter and shift key together -> see error

Expected behavior
1 . Change to input box that cannot use new line

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
METATRON-1581
@paigechoi paigechoi added the @dataprep Component Name : Data preparation label Feb 27, 2019
paigechoi added a commit that referenced this issue Feb 28, 2019
@paigechoi
#1532 Fix input for dataset name
6170cc1 
- Add css
paigechoi added a commit that referenced this issue Feb 28, 2019
@paigechoi
#1532 Fix input for snapshot name
7eec5eb 
- Fix markup
@paigechoi paigechoi mentioned this issue Mar 4, 2019
Merged
9 tasks
kaypark-skt pushed a commit that referenced this issue Mar 5, 2019
@paigechoi @kaypark-skt
F#1532 fix dataprep name input (#1567)
50c44fe 
* #1532 Fix input for dataset name
- Add css

* #1532 Fix input for snapshot name
- Fix markup
@kaypark-skt kaypark-skt added this to the 3.2.0 milestone Mar 5, 2019
@joohokim1 joohokim1 added the bug Something isn't working label Mar 6, 2019
@joohokim1
Copy link
Contributor

1st integrated test passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paigechoi paigechoi

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

@kaypark-skt kaypark-skt

Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
4 participants
@paigechoi @sang-hee-lee @joohokim1 @kaypark-skt