Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot table name validation #1579

Closed
paigechoi opened this issue Mar 6, 2019 · 1 comment
Closed

Add snapshot table name validation #1579

paigechoi opened this issue Mar 6, 2019 · 1 comment
Assignees
@paigechoi @sang-hee-lee @joohokim1 @kaypark-skt
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Milestone
3.2.0

Comments

@paigechoi
Copy link
Contributor

paigechoi commented Mar 6, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
When creating snapshot, snapshot table name should only allow
alphanumeric and _ .
no white space in table name.
Default value of snapshot table name is Snapshot1

Describe the solution you'd like
When done button is clicked, validate snapshot table name.
If validation fails show error message.

Describe alternatives you've considered

Additional context
Add any other context or screenshots about the feature request here.
@paigechoi paigechoi added the @dataprep Component Name : Data preparation label Mar 6, 2019
paigechoi added a commit that referenced this issue Mar 6, 2019
@paigechoi
#1579 Add snapshot table name validation
02ccb9e 
- Show error msg instead of alerts
paigechoi added a commit that referenced this issue Mar 6, 2019
@paigechoi
#1579 Add language file
0e7136d
paigechoi added a commit that referenced this issue Mar 6, 2019
@paigechoi
#1579 Fix validation message to required (when empty)
9f18b0e
@paigechoi paigechoi mentioned this issue Mar 6, 2019
Merged
9 tasks
@joohokim1 joohokim1 added the enhancement Request Change and Feature Enhancement label Mar 6, 2019
@joohokim1 joohokim1 added this to the 3.2.0 milestone Mar 6, 2019
kaypark-skt pushed a commit that referenced this issue Mar 6, 2019
@kaypark-sk
#1579 if stagedb is not in configuration, teddy will not use the value
ef3b9b2
joohokim1 pushed a commit that referenced this issue Mar 6, 2019
@paigechoi @joohokim1
F#1579 add snapshot table name validation (#1585)
89dec7e 
* #1579 Add snapshot table name validation
- Show error msg instead of alerts

* #1579 Add language file

* #1579 Fix validation message to required (when empty)

* #1579 if stagedb is not in configuration, teddy will not use the value
@kaypark-skt kaypark-skt added testbed2 Review Test Server 2 enhancement Request Change and Feature Enhancement and removed enhancement Request Change and Feature Enhancement testbed2 Review Test Server 2 labels Mar 7, 2019
@joohokim1
Copy link
Contributor

2nd integrated test passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paigechoi paigechoi

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

@kaypark-skt kaypark-skt

Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
4 participants
@paigechoi @sang-hee-lee @joohokim1 @kaypark-skt