Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong stage index after REDO #1599

Closed
joohokim1 opened this issue Mar 7, 2019 · 0 comments
Closed

Wrong stage index after REDO #1599

joohokim1 opened this issue Mar 7, 2019 · 0 comments
Assignees
@joohokim1
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone
3.2.0

Comments

@joohokim1
Copy link
Contributor

Describe the bug
When I did UNDO and REDO, the stage index went wrong.

To Reproduce

  1. Import & wrangle sample.csv.txt
  2. Edit rules
  3. Drop column6
  4. Edit the last rule and change to drop column5
  5. Press Undo (sth like ↪️ above the rule list)
  6. Press Redo
  7. Suddenly, the 2nd last stage is shown.

Expected behavior
The last stage should be shown.

Screenshots
2019-03-07 3 36 04

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version: 68.0.3440.106

Additional context
The column highlight is not important.
@joohokim1 joohokim1 added bug Something isn't working @dataprep Component Name : Data preparation labels Mar 7, 2019
@joohokim1 joohokim1 added this to the 3.2.0 milestone Mar 7, 2019
@joohokim1 joohokim1 self-assigned this Mar 7, 2019
joohokim1 added a commit that referenced this issue Mar 11, 2019
@joohokim1
#1599 put the right stageIdx to the new revision after UPDATE
a255b76
joohokim1 added a commit that referenced this issue Mar 11, 2019
@joohokim1
#1599 merge removes target columns
c481236
joohokim1 added a commit that referenced this issue Mar 11, 2019
@joohokim1
#1599 do not auto header if not appropriated
29aee7b
@joohokim1 joohokim1 mentioned this issue Mar 11, 2019
Merged
9 tasks
joohokim1 added a commit that referenced this issue Mar 12, 2019
@joohokim1
#1599 wrong stage idx after redo
4209941 
* #1599 put the right stageIdx to the new revision after UPDATE

* #1599 merge removes target columns

* #1599 do not auto header if not appropriated
joohokim1 added a commit that referenced this issue Mar 15, 2019
@joohokim1
Revert "#1599 wrong stage idx after redo"
2c05160 
This reverts commit 4209941.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joohokim1 joohokim1

Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
1 participant
@joohokim1