Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URI type dataset support #1644

Closed
minjung-cho opened this issue Mar 12, 2019 · 9 comments
Closed

URI type dataset support #1644

minjung-cho opened this issue Mar 12, 2019 · 9 comments
Assignees
@minjung-cho @paigechoi @joohokim1
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Milestone
3.2.0

Comments

@minjung-cho
Copy link

minjung-cho commented Mar 12, 2019 •
edited
Loading

Problem
We need to support file datasets which are not uploaded by browser, but located on designated locations like HDFS, S3, etc.

Solution
스크린샷 2019-03-15 오후 3 49 16
스크린샷 2019-03-15 오후 3 51 49
스크린샷 2019-03-20 오후 1 53 13
스크린샷 2019-03-20 오후 1 53 22
스크린샷 2019-03-15 오후 3 49 26

Alternatives
None

Additional context
METATRON-1584
@minjung-cho minjung-cho added the @dataprep Component Name : Data preparation label Mar 12, 2019
@minjung-cho minjung-cho self-assigned this Mar 12, 2019
@joohokim1 joohokim1 self-assigned this Mar 12, 2019
@joohokim1 joohokim1 added the enhancement Request Change and Feature Enhancement label Mar 12, 2019
@joohokim1 joohokim1 added this to the 3.2.0 milestone Mar 12, 2019
@koeun222
Copy link

koeun222 commented Mar 14, 2019 •
edited
Loading

@AnnieHwang 디자인 공유드립니다-

  1. 생성화면 : "URI"의 메타포를 링크로 넣었는데 적당할지 검토 부탁드려요-
    image

  2. 생성 > URI 1단계
    image

  3. 생성 > URI 2단계
    Edit dataset immediately after creation in Prep #1516 이슈의 Single file 업로드시 화면과 레이아웃 동일합니다

@AnnieHwang
Copy link
Contributor

@minjung-cho @koen222 1번 타입 선택에서는 'URI' 였는데 2번 스텝에서 타이틀이 'Create File URI XXXX' 인 것이 이상해요. 둘다 'File URI'이거나, 'URI'여야 할것 같습니다.

@koeun222
Copy link

@AnnieHwang 네에~ 1번 타입 선택화면을 "File URI"로 명칭 통일해서 퍼블 전달합니다-

@AnnieHwang
Copy link
Contributor

@koeun222 저... 아직 퍼블 넘기지 말아주세요. URI를 URL로 바꾸고 File URI만이 아니라 모든 URL로 커버 하도록 바꾸기로 해서요. 문구 정정이 필요할꺼 같아요

@koeun222
Copy link

"URI , File URI" --------> "URL"로 변경되었습니다-

@minjung-cho minjung-cho added the awaiting feedback need to feedback label Mar 15, 2019
@minjung-cho
Copy link
Author

@AnnieHwang @joohokim1 조금 전 논의한 내용 반영했습니다. 확인 부탁드립니다-

@AnnieHwang
Copy link
Contributor

@minjung-cho 확인했습니다!

@joohokim1
Copy link
Contributor

@minjung-cho @AnnieHwang 저도 확인했습니다!

@joohokim1 joohokim1 removed the awaiting feedback need to feedback label Mar 15, 2019
@minjung-cho
Copy link
Author

minjung-cho commented Mar 20, 2019 •
edited
Loading

@sang-hee-lee 누락된 화면(csv, txt, excel)에 대한 와이어프레임을 본문에 추가하였습니다. 타 이슈(#1515 #1374 등)에서와 동일한 기능 및 콤포넌트인지라, 설명을 따로 캡쳐하진 않았습니다. 문서에는 있으니 참고 부탁드립니다.
@joohokim1 @AnnieHwang 검토 한번 부탁드립니다-

@minjung-cho minjung-cho added the awaiting feedback need to feedback label Mar 20, 2019
@joohokim1 joohokim1 removed the awaiting feedback need to feedback label Mar 22, 2019
@paigechoi paigechoi self-assigned this Mar 25, 2019
@joohokim1 joohokim1 mentioned this issue Mar 25, 2019
Closed
paigechoi added a commit that referenced this issue Mar 25, 2019
@paigechoi
#1644 Make dataset with url
67f9952 
- Add CreateDatasetSelecturlComponent
- Add css, icon, svg regarding url
paigechoi added a commit that referenced this issue Mar 25, 2019
@paigechoi
#1644 Fix validation logic in create dataset with url (first step)
cf098b4
paigechoi added a commit that referenced this issue Mar 25, 2019
@paigechoi
#1644 Add validation logic for delimiter and column cnt
7fbdd7f 
- fix typos as well
paigechoi added a commit that referenced this issue Mar 26, 2019
@paigechoi
#1644 Check delimiter and column cnt when enter is pressed or check b…
33cdac8 
…tn is clicked.

- change language file
paigechoi added a commit that referenced this issue Mar 26, 2019
@paigechoi
#1644 Fix title of popup depending on type of data
7c41063
kaypark-skt pushed a commit that referenced this issue Mar 26, 2019
@kaypark-sk
#1644 server also supports URI type
f87f4a2
@kaypark-skt kaypark-skt mentioned this issue Mar 26, 2019
Merged
9 tasks
paigechoi added a commit that referenced this issue Mar 26, 2019
@paigechoi
#1644 Fix deleted code
031bb65
paigechoi added a commit that referenced this issue Mar 27, 2019
@paigechoi
#1644 change validation check to load data
8b26be3
paigechoi added a commit that referenced this issue Mar 27, 2019
@paigechoi
#1644 Remove advanced setting when there's no grid data
9c4d6e1
paigechoi added a commit that referenced this issue Mar 27, 2019
@paigechoi
#1644 Remove advanced setting when file type is json
28d9735
paigechoi added a commit that referenced this issue Mar 27, 2019
@paigechoi
#1644 fix dataflow detail network chart
22d79c9 
- did not show chart when import type is uri
joohokim1 pushed a commit that referenced this issue Mar 27, 2019
@kaypark-skt @joohokim1
1644 uri type dataset support
d3bc84c 
* #1644 Make dataset with url
- Add CreateDatasetSelecturlComponent
- Add css, icon, svg regarding url

* #1644 Fix validation logic in create dataset with url (first step)

* #1644 Add validation logic for delimiter and column cnt
- fix typos as well

* #1644 Check delimiter and column cnt when enter is pressed or check btn is clicked.
- change language file

* #1644 Fix title of popup depending on type of data

* #1644 server also supports URI type

* #1644 Fix deleted code

* #1644 change validation check to load data

* #1644 Remove advanced setting when there's no grid data

* #1644 Remove advanced setting when file type is json

* #1644 fix dataflow detail network chart
- did not show chart when import type is uri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minjung-cho minjung-cho

@paigechoi paigechoi

@joohokim1 joohokim1

Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
5 participants
@AnnieHwang @minjung-cho @paigechoi @koeun222 @joohokim1