Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The maximum number of characters in the dataset name is too short #1647

Closed
minjung-cho opened this issue Mar 12, 2019 · 3 comments
Closed

The maximum number of characters in the dataset name is too short #1647

minjung-cho opened this issue Mar 12, 2019 · 3 comments
Assignees
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Milestone

Comments

@minjung-cho
Copy link

minjung-cho commented Mar 12, 2019

Problem
원소스가 엑셀인 경우, '파일명+시트명'이 데이터셋의 기본값으로 입력되는데, 꽤 길이가 긴 경우가 있습니다. 이때, 입력 가능한 문자 수가 50자로 제한되어 있어서 '데이터셋 생성 완료' 까지 매끄럽게 이어지지 않습니다.
If the source is excel, 'filename + sheet name' is entered as the dataset default, which may be quite long. At this time, since the number of characters that can be input is limited to 50 characters, it does not lead smoothly to 'dataset creation completion'.

Solution
(한)

  1. 데이터셋 이름을 150자까지 입력 가능하도록 변경합니다. (기존 50자)
  2. 데이터셋 이름 초기값이 150자를 초과할 경우, 자동으로 150자까지만 입력시켜 줍니다.
  3. 사용자가 150자를 초과하여 입력하려고 할때, 입력 박스에 '150자까지 입력할 수 있습니다'라는 메시지를 보여줍니다.

(영)

  1. Change the dataset name to allow input of up to 150 characters. (Original 50 characters)
  2. If the initial value of the dataset name exceeds 150 characters, it will automatically enter up to 150 characters.
  3. When the user tries to input more than 150 characters, the input box shows the message 'You can enter up to 150 characters'.

UI sample
스크린샷 2019-03-12 오후 6 52 19

Alternatives
None

Additional context
설명 부분에 입력 수 제한이 있다면, 이 또한 위에서 정의한 것과 같은 UX가 적용되어야 합니다.
If there is a limit on the number of entries in the description part, this also applies to UX as defined above.

@minjung-cho minjung-cho added the @dataprep Component Name : Data preparation label Mar 12, 2019
@minjung-cho minjung-cho self-assigned this Mar 12, 2019
@joohokim1 joohokim1 self-assigned this Mar 12, 2019
@joohokim1 joohokim1 added the enhancement Request Change and Feature Enhancement label Mar 12, 2019
@joohokim1 joohokim1 added this to the 3.2.0 milestone Mar 12, 2019
@minjung-cho minjung-cho added the awaiting feedback need to feedback label Mar 13, 2019
@joohokim1
Copy link
Contributor

@minjung-cho @AnnieHwang
검토 완료했습니다. @sang-hee-lee 이대로 진행하시면 좋을 것 같습니다.

@joohokim1 joohokim1 removed the awaiting feedback need to feedback label Mar 13, 2019
@minjung-cho
Copy link
Author

@koeun222 @paigechoi 데이터 플로우 화면에서 이름에 말줄임 처리가 안되어 있는 것 같습니다. 추가 부탁드립니다-

@koeun222
Copy link

koeun222 commented Mar 14, 2019

@paigechoi 에러문구는 공통ui 적용해주시고, 에러문구 노출 후 2초뒤 사라지도록 퍼블 작업부탁드립니다-

paigechoi added a commit that referenced this issue Mar 14, 2019
- Default value is 150 max, slice if longer than 150
- Show error msg if user tries to enter more than 150 letters
- Add browser tooltip for dataset name
paigechoi added a commit that referenced this issue Mar 15, 2019
- show ... when dataset name is too long
- add browser tooltip
paigechoi added a commit that referenced this issue Mar 15, 2019
paigechoi added a commit that referenced this issue Mar 15, 2019
- fix black and white hive svg icon
joohokim1 pushed a commit that referenced this issue Mar 18, 2019
#1647 Allow dataset name max length to be 150
- Default value is 150 max, slice if longer than 150
- Show error msg if user tries to enter more than 150 letters
- Add browser tooltip for dataset name

* #1647 Fix dataset name span tag css in multi column rename
- show ... when dataset name is too long
- add browser tooltip

* #1647 Add comment for methods

* #1647 Fix snapshot name css error when name is too long
- fix black and white hive svg icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants