Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat null values and empty strings the same way. #2243

Closed
joohokim1 opened this issue Jun 17, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@joohokim1
Copy link
Contributor

commented Jun 17, 2019

Is your feature request related to a problem? Please describe.
Recently, I've received a question that why the empty strings are shown as mismatched not as missing.
My answer was that they are diffent as a perspective of a programmer, but she said it's very confusing.
Besides, I found out a similar product also treats the two values as the same.
So, I realized that normal users do not want to distinguish those two.

Describe the solution you'd like
Show empty strings as missing in Histogram (above the grid of data preparation edit page).
The grid itself has no change.

Additional context
I was going to solve this issue as below:
1. Show null values as empty string in UI. (null) will not be shown on grid any more.
2. Treat empty string as missing in histogram bar.
3. Internal corresponding code change.

NULL vs Empty String is not finished yet.
I want to talk about this matter with other contributors.
If needed, let's open an issue about this tiresome but important thing.

This issue must be done before #2241.

@joohokim1 joohokim1 added this to the 3.3.0 milestone Jun 17, 2019

@joohokim1 joohokim1 self-assigned this Jun 17, 2019

joohokim1 added a commit that referenced this issue Jun 17, 2019

joohokim1 added a commit that referenced this issue Jun 17, 2019

@joohokim1 joohokim1 referenced this issue Jun 17, 2019

Merged

F#2243 show null as missing #2245

1 of 7 tasks complete

joohokim1 added a commit that referenced this issue Jun 17, 2019

#2243 show null values and empty strings both as missing in histograms
* #2243 Removed type change by value

* #2243 Null values are now shown as missing in Histogram.

@joohokim1 joohokim1 closed this Jun 17, 2019

@joohokim1

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

Integrated test #1 passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.