Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error during processing db connection in workbench #2250

Closed
ufoscw opened this issue Jun 18, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@ufoscw
Copy link
Contributor

commented Jun 18, 2019

Is your feature request related to a problem? Please describe.
Currently, the release_mode of the hibernate connection is on_close (default), which keeps the connection until the hibernate session is closed.
There is a risk of error if it does not match db timeout setting.
Also, resources are wasted due to connection.
So we need to change it to after_transaction to release it at the end of the transaction.

Describe the solution you'd like
add properties to application.yaml

spring:
  jpa:
    properties:
      hibernate:
        connection:
          release_mode: after_transaction

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@ufoscw ufoscw added the @common label Jun 18, 2019

@ufoscw ufoscw added this to the 3.3.0 milestone Jun 18, 2019

@ufoscw ufoscw self-assigned this Jun 18, 2019

ufoscw added a commit that referenced this issue Jun 18, 2019

@ufoscw ufoscw referenced this issue Jun 18, 2019

Merged

#2250 change hibernate connection properties #2251

0 of 7 tasks complete

ufoscw added a commit that referenced this issue Jun 19, 2019

@ufoscw ufoscw closed this Jun 19, 2019

@kyungtaak kyungtaak changed the title change hibernate connection properties Fix error during processing db connection in workbench Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.