Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create dataset with JSON file #841

Closed
mh0203 opened this issue Nov 22, 2018 · 6 comments
Closed

Create dataset with JSON file #841

mh0203 opened this issue Nov 22, 2018 · 6 comments
Assignees
@mh0203 @joohokim1
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Milestone
3.1.0

Comments

@mh0203
Copy link
Contributor

mh0203 commented Nov 22, 2018

Is your feature request related to a problem? Please describe.
Now we support dataset creation with excel, csv and txt files.
Let's also support json files.

Describe the solution you'd like
Allow Json file when making file type imported dataset.

Describe alternatives you've considered

Additional context
We should support json file type snapshot soon.
@mh0203 mh0203 added the @dataprep Component Name : Data preparation label Nov 22, 2018
@mh0203 mh0203 added this to the 3.1.0 milestone Nov 22, 2018
@mh0203
Copy link
Contributor Author

mh0203 commented Nov 22, 2018

Serve side job: JSON parsing and JSON to CSV converting logic.
Clinet side job: Allow json file type upload and change some phrases.

@mh0203
Copy link
Contributor Author

mh0203 commented Nov 22, 2018

screen shot 2018-11-22 at 10 02 12 am

@mh0203
Copy link
Contributor Author

mh0203 commented Nov 22, 2018 •
edited
Loading

screen shot 2018-11-22 at 10 06 20 am

상기 코멘트와 달리 Delimiter 입력박스를 단순히 삭제해주시면 됩니다.

mh0203 added a commit that referenced this issue Nov 26, 2018
@mh0203
#841 Create dataset with json file
80c8241
@mh0203
Copy link
Contributor Author

mh0203 commented Nov 26, 2018

screen shot 2018-11-26 at 2 55 33 pm

@mh0203 mh0203 assigned sang-hee-lee and unassigned mh0203 Nov 26, 2018
mh0203 added a commit that referenced this issue Nov 26, 2018
@mh0203
#841 Change json parsing library from json simple to jackson
66c1d15
sang-hee-lee added a commit that referenced this issue Nov 26, 2018
@sang-hee-lee
#841 add json type
a4909cd
paigechoi added a commit that referenced this issue Nov 27, 2018
@paigechoi
#841 delete json type snapshot create option
c154837
@paigechoi paigechoi assigned mh0203 and unassigned sang-hee-lee Nov 28, 2018
@mh0203 mh0203 mentioned this issue Dec 3, 2018
Merged
9 tasks
mh0203 added a commit that referenced this issue Dec 3, 2018
@mh0203
#841 Create dataset with json file
5743424
mh0203 added a commit that referenced this issue Dec 3, 2018
@mh0203
#841 Change json parsing library from json simple to jackson
6fa5c4c
mh0203 pushed a commit that referenced this issue Dec 3, 2018
@sang-hee-lee @mh0203
#841 add json type
d4c0370
mh0203 pushed a commit that referenced this issue Dec 3, 2018
@paigechoi @mh0203
#841 delete json type snapshot create option
883a1b7
@joohokim1 joohokim1 added the enhancement Request Change and Feature Enhancement label Dec 6, 2018
@joohokim1
Copy link
Contributor

Integrated test 1 passed.

@joohokim1
Copy link
Contributor

During the 2nd integration test, JSON was not able to import.
Maybe there was some problem while merging # 908.
@Ksparknot is working on it.
PR will be created with a new branch.

2번째 통합테스트 중에 JSON이 import가 안되는 문제가 발생했습니다.
아마 #908을 merge하는 중에 문제가 생긴 것 같습니다.
관련해서 @ksparknot 님께서 작업 중입니다.
새로운 branch로 PR이 만들어질 예정입니다.

kaypark-skt pushed a commit that referenced this issue Dec 7, 2018
@kaypark-sk
#841 convert json to csv
34f037e
@kaypark-skt kaypark-skt mentioned this issue Dec 7, 2018
Merged
9 tasks
kaypark-skt added a commit that referenced this issue Dec 7, 2018
@kaypark-skt
Merge pull request #1041 from metatron-app/f#841-Create_dataset_with_…
cab5d1e 
…JSON_file-FIX

#841 convert json to csv
alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@mh0203 @alchan-lee
#841 Create dataset with json file
389f05b
alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@mh0203 @alchan-lee
#841 Change json parsing library from json simple to jackson
9105838
alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@sang-hee-lee @alchan-lee
#841 add json type
c3a0a0b
alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@paigechoi @alchan-lee
#841 delete json type snapshot create option
8e6d616
alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@kaypark-sk @alchan-lee
#841 convert json to csv
6fcf107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mh0203 mh0203

@joohokim1 joohokim1

Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
3 participants
@mh0203 @sang-hee-lee @joohokim1