Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error deleting multiple expressions #917

Closed
sang-hee-lee opened this issue Nov 27, 2018 · 1 comment
Closed

Fixed error deleting multiple expressions #917

sang-hee-lee opened this issue Nov 27, 2018 · 1 comment
Assignees
@sang-hee-lee @joohokim1
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone
3.1.0

Comments

@sang-hee-lee
Copy link
Contributor

Describe the bug
Deletes the last expression when deleting an expression.

To Reproduce
Steps to reproduce the behavior:

  1. menu > MANAGEMENT > DataPreparation
  2. click Dataflow > click Wrangled Data > Edit rules
  3. add rule : window, pivot, aggregate
  4. Add two or more expressions and click the Delete Expression button

Expected behavior
If you press the delete button, the corresponding location expression is deleted

Screenshots

Additional context
@sang-hee-lee sang-hee-lee added bug Something isn't working @dataprep Component Name : Data preparation labels Nov 27, 2018
@sang-hee-lee sang-hee-lee added this to the 3.1.0 milestone Nov 27, 2018
sang-hee-lee added a commit that referenced this issue Nov 28, 2018
@sang-hee-lee
#917 fix deleting multiple expressions
979b4d6
sang-hee-lee added a commit that referenced this issue Nov 29, 2018
@sang-hee-lee
#917 modify expression check message
268f6e8
sang-hee-lee added a commit that referenced this issue Dec 3, 2018
@sang-hee-lee
#917 modify expression button
fbd5a5a
paigechoi added a commit that referenced this issue Dec 4, 2018
@paigechoi
#917 fix context menu error
1ab2a31
@sang-hee-lee sang-hee-lee mentioned this issue Dec 5, 2018
Merged
9 tasks
sang-hee-lee added a commit that referenced this issue Dec 5, 2018
@sang-hee-lee
#917 modify split min value
ca97422
sang-hee-lee added a commit that referenced this issue Dec 5, 2018
@sang-hee-lee
#917 fix rule edit
b64c010
sang-hee-lee added a commit that referenced this issue Dec 6, 2018
@sang-hee-lee
#917 fix deleting multiple expressions
fb8a9ea
sang-hee-lee added a commit that referenced this issue Dec 6, 2018
@sang-hee-lee
#917 modify expression check message
2a7d6b5
sang-hee-lee added a commit that referenced this issue Dec 6, 2018
@sang-hee-lee
#917 modify expression button
ea8fda5
sang-hee-lee pushed a commit that referenced this issue Dec 6, 2018
@paigechoi @sang-hee-lee
#917 fix context menu error
0bc8226
sang-hee-lee added a commit that referenced this issue Dec 6, 2018
@sang-hee-lee
#917 modify split min value
5fc588c
sang-hee-lee added a commit that referenced this issue Dec 6, 2018
@sang-hee-lee
#917 fix rule edit
597690a
@joohokim1
Copy link
Contributor

Integrated test 2 passed.

alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@sang-hee-lee @alchan-lee
#917 fix deleting multiple expressions
c376694
alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@sang-hee-lee @alchan-lee
#917 modify expression check message
f3ff58a
alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@sang-hee-lee @alchan-lee
#917 modify expression button
59621ca
alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@paigechoi @alchan-lee
#917 fix context menu error
a6594a0
alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@sang-hee-lee @alchan-lee
#917 modify split min value
eabf01d
alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@sang-hee-lee @alchan-lee
#917 fix rule edit
fbb5c8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
2 participants
@sang-hee-lee @joohokim1