Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split rule error in dataprep #929

Closed
paigechoi opened this issue Nov 28, 2018 · 2 comments
Closed

Split rule error in dataprep #929

paigechoi opened this issue Nov 28, 2018 · 2 comments
Assignees
@paigechoi @sang-hee-lee @joohokim1
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone
3.1.0

Comments

@paigechoi
Copy link
Contributor

paigechoi commented Nov 28, 2018 •
edited
Loading

Describe the bug
When applying split rule in dataprep, Number of times is mandatory field but still works without it

To Reproduce
Steps to reproduce the behavior:
Dataflow main grid -> select split -> add rule without Number of times -> see error

Expected behavior
If Number of times is empty user should be warned with an alert saying Number of times is mandatory field

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
Similar Unpivot & move error will be be resolved here.
@paigechoi paigechoi added bug Something isn't working @dataprep Component Name : Data preparation labels Nov 28, 2018
@paigechoi paigechoi added this to the 3.1.0 milestone Nov 28, 2018
paigechoi added a commit that referenced this issue Nov 28, 2018
@paigechoi
#929 fix unpivot, split, move error (some fields are mandatory), fix …
1798a0c 
…edit & delete overlapping css
@paigechoi paigechoi mentioned this issue Nov 28, 2018
Merged
9 tasks
paigechoi added a commit that referenced this issue Nov 29, 2018
@paigechoi
#929 fix unpivot, split, move error (some fields are mandatory), fix …
e03a2fd 
…edit & delete overlapping css
@joohokim1
Copy link
Contributor

Integrated test 1 passed.

@joohokim1
Copy link
Contributor

Integrated test 2 passed.

alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@paigechoi @alchan-lee
#929 fix unpivot, split, move error (some fields are mandatory), fix …
e541cd6 
…edit & delete overlapping css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paigechoi paigechoi

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
3 participants
@paigechoi @sang-hee-lee @joohokim1