Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous selection is initialised in Create DB type dataset #933

Closed
paigechoi opened this issue Nov 28, 2018 · 1 comment
Closed

Previous selection is initialised in Create DB type dataset #933

paigechoi opened this issue Nov 28, 2018 · 1 comment
Assignees
@paigechoi @sang-hee-lee @joohokim1
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone
3.1.0

Comments

@paigechoi
Copy link
Contributor

Describe the bug
When previous button is clicked in Create DB type dataset, all selection is refreshed.

To Reproduce
Steps to reproduce the behavior:
See screenshot
image
image

Expected behavior
Selection should not be refreshed

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@paigechoi paigechoi added bug Something isn't working @dataprep Component Name : Data preparation labels Nov 28, 2018
@paigechoi paigechoi added this to the 3.1.0 milestone Nov 28, 2018
paigechoi added a commit that referenced this issue Nov 29, 2018
@paigechoi
#933 show error msg when next button is clicked without validation
74c525c
paigechoi added a commit that referenced this issue Nov 29, 2018
@paigechoi
#933 fix db type refresh issue when creating dataset, add contents in…
67ed72b 
… summary (dataset create last step), fix translation
paigechoi added a commit that referenced this issue Nov 29, 2018
@paigechoi
#933 fix refresh issue when creating staging db dataset
6350eda
paigechoi added a commit that referenced this issue Dec 3, 2018
@paigechoi
#933 fix staging db refresh when moving to previous stage
ba43242
paigechoi added a commit that referenced this issue Dec 4, 2018
@paigechoi
#933 set previous selected values when going through steps in creatin…
aff867f 
…g dataset (db)
paigechoi added a commit that referenced this issue Dec 4, 2018
@paigechoi
#933 Fix validation error when using query in creating dataset (db)
b84643f
paigechoi added a commit that referenced this issue Dec 4, 2018
@paigechoi
#933 fix validation in creating dataset (staging db)
8334dac
paigechoi added a commit that referenced this issue Dec 4, 2018
@paigechoi
merge #933 to 3.1.0
fb4c13f
@paigechoi paigechoi mentioned this issue Dec 4, 2018
Merged
9 tasks
paigechoi added a commit that referenced this issue Dec 4, 2018
@paigechoi
F#933 fix create dbtype refresh issue (#1002)
b5b9d10 
* #933 show error msg when next button is clicked without validation

* #933 fix db type refresh issue when creating dataset, add contents in summary (dataset create last step), fix translation

* #933 fix refresh issue when creating staging db dataset

* #933 fix staging db refresh when moving to previous stage

* #933 set previous selected values when going through steps in creating dataset (db)

* #933 Fix validation error when using query in creating dataset (db)

* #933 fix validation in creating dataset (staging db)
@joohokim1
Copy link
Contributor

Integrated test 2 passed.

alchan-lee pushed a commit that referenced this issue Dec 7, 2018
@paigechoi @alchan-lee
F#933 fix create dbtype refresh issue (#1002)
40e1c5a 
* #933 show error msg when next button is clicked without validation

* #933 fix db type refresh issue when creating dataset, add contents in summary (dataset create last step), fix translation

* #933 fix refresh issue when creating staging db dataset

* #933 fix staging db refresh when moving to previous stage

* #933 set previous selected values when going through steps in creating dataset (db)

* #933 Fix validation error when using query in creating dataset (db)

* #933 fix validation in creating dataset (staging db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paigechoi paigechoi

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
3 participants
@paigechoi @sang-hee-lee @joohokim1