Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add displaying error message when failing query (step of JDBC data source creation) #941

Closed
kyungtaak opened this issue Nov 28, 2018 · 5 comments
Closed

Add displaying error message when failing query (step of JDBC data source creation) #941

kyungtaak opened this issue Nov 28, 2018 · 5 comments
Assignees
@ufoscw @brandon-wonjune
Labels
@datasource Component Name : Datasource/Connection Management enhancement Request Change and Feature Enhancement p1 Priority 1
Milestone
3.2.0

Comments

@kyungtaak
Copy link
Contributor

Is your feature request related to a problem? Please describe.
현재 아래와 같이 Query 로 Preview 조회시 오류가 발생하면 오류내용을 알수 있는 방업이 없습니다.

image

Describe the solution you'd like
쿼리 수행 중 오류 발생시 오류의 내용에 대해 DB 에서 전달되는 오류 메시지를 처리했으면 합니다.
@metatron-app/design 에서 검토 부탁드립니다.

Describe alternatives you've considered
(N/A)

Additional context
워크벤치내에서 쿼리오류 표시와 유사한 형태로 진행했으면 합니다.
@kyungtaak kyungtaak added enhancement Request Change and Feature Enhancement @datasource Component Name : Datasource/Connection Management labels Nov 28, 2018
@kyungtaak kyungtaak added this to the 3.2.0 milestone Nov 28, 2018
@AnnieHwang
Copy link
Contributor

@kyungtaak 개선에 여지가 있어보입니다. @deidera08 워크벤치를 참고하여 해당 화면을 좀 바꿔보면 좋을 것 같습니다.
image

@kyungtaak kyungtaak added the p1 Priority 1 label Nov 30, 2018
@deidera08
Copy link

@kyungtaak @AnnieHwang
쿼리 실행시 서버 오류 메세지는 데이터 미리보기 화면에 노출하면 좋을듯합니다.
941queryerrormsg

워크벤치의 경우 output탭을 분리하여 log등을 노출하는데, 그 정도의 기능까지는 필요하지 않은 듯 하고, 단순히 오류메세지 정도라면 미리보기 화면이면 적당할 듯 합니다.

@deidera08 deidera08 mentioned this issue Jan 15, 2019
Open
@deidera08
Copy link

deidera08 commented Jan 15, 2019 •
edited
Loading

@kyungtaak @AnnieHwang
#1175이슈를 정리하면서 화면이 보완되었습니다. 해당 이슈를 참고부탁드립니다.

@brandon-wonjune brandon-wonjune self-assigned this Feb 11, 2019
@ufoscw ufoscw self-assigned this Feb 11, 2019
@brandon-wonjune
Copy link
Contributor

@deidera08
#630 이슈에서 사용된 code가 동일하게 내려오고있는데요.
지금은 현재 #630 이슈에서 설정된 message로 표기하고있는데 이것도 서버에서 내려주는 message를 그대로 보여주는되는건가요?
아니면 별개의 상황으로 봐야되나요?

@deidera08
Copy link

deidera08 commented Feb 11, 2019 •
edited
Loading

@brandon-wonjune
별개의 상황은 아닙니다만 Query화면에서는 서버에서 내려주는 message를 그대로 보여주는쪽이 유저에게 더 명확할 듯 합니다.

brandon-wonjune added a commit that referenced this issue Feb 12, 2019
@brandon-wonjune
#941 fix grid component css
d16f068
brandon-wonjune added a commit that referenced this issue Feb 12, 2019
@brandon-wonjune
#941 add error message in query type data preview
e18dca2
brandon-wonjune added a commit that referenced this issue Feb 12, 2019
@brandon-wonjune
#941 fix not exist table list guide message in create source step
6d9fbb8
@brandon-wonjune brandon-wonjune mentioned this issue Feb 12, 2019
Merged
9 tasks
ufoscw pushed a commit that referenced this issue Feb 13, 2019
@brandon-wonjune @ufoscw
#941 add error message query source create (#1418)
ab81db3 
* #941 fix grid component css

* #941 add error message in query type data preview

* #941 fix not exist table list guide message in create source step
@ufoscw ufoscw closed this as completed Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ufoscw ufoscw

@brandon-wonjune brandon-wonjune

Labels
@datasource Component Name : Datasource/Connection Management enhancement Request Change and Feature Enhancement p1 Priority 1
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
5 participants
@kyungtaak @ufoscw @AnnieHwang @brandon-wonjune @deidera08