Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message is not intuitive for expression parsing error (dataprep) #985

Closed
joohokim1 opened this issue Dec 3, 2018 · 0 comments
Closed
Assignees
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone

Comments

@joohokim1
Copy link
Contributor

joohokim1 commented Dec 3, 2018

Describe the bug
When I entered an expression which started with number error toast pops out.
Then I clicked, the "click to see detail", and I get this message.

For input string: "22222222222222222222222222"

This error message is rather not intuitive.

To Reproduce
Steps to reproduce the behavior:

  1. Import and wrangle any dataset
  2. Select set rule
  3. Enter 222222222222222222 in expression input box.
  4. See error

Expected behavior
Minimum: Expression parsing error: "222222222222222222222"
Better: Expression parsing error on: "222222222222222222222"
Best: Expression parsing error: wrong identifier: "22222222222222222"
One of messages above should be shown in the popup box, regardless of the first error message in the toast component.

Screenshots
181127_dataflow_rule_set_error_00
181127_dataflow_rule_set_error_01

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version: 68.0.3440.106
@joohokim1 joohokim1 added the bug Something isn't working label Dec 3, 2018
@kyungtaak kyungtaak added the @dataprep Component Name : Data preparation label Dec 3, 2018
@joohokim1 joohokim1 added this to the 3.2.0 milestone Dec 7, 2018
@mh0203 mh0203 closed this as completed Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Development

No branches or pull requests

3 participants