Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#973 Sorting function of data table does not work properly. #1111

Merged
merged 1 commit into from
Jan 9, 2019
Merged

#973 Sorting function of data table does not work properly. #1111

merged 1 commit into from
Jan 9, 2019

Conversation

YooYoungmo
Copy link
Collaborator

Description

Text Table 차트 피벗 모드에서 정렬이 제대로 되지 않은 문제를 해결 하였습니다.
싱세한 오류 내용은 #973 이슈에 기록해 두었습니다.

Related Issue :
#973

How Has This Been Tested?

  • Rest TestCase 를 작성하여 테스트 하였습니다.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project. it will be added soon
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. it will be added soon
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Additional Context

@ufoscw ufoscw added testbed6 @chart Chart Component and Widget labels Dec 19, 2018
@ufoscw
Copy link
Contributor

ufoscw commented Dec 19, 2018

run build
deploy to 6

@metatron-ci-bot

This comment has been minimized.

Sign in to view
@alchan-lee
Copy link
Contributor

run build
deploy to 6

@YooYoungmo YooYoungmo force-pushed the f#973-error_sorting_function_in_text_table_chart branch from 666fbc5 to bf70520 Compare December 19, 2018 06:39
@YooYoungmo YooYoungmo force-pushed the f#973-error_sorting_function_in_text_table_chart branch from bf70520 to 97b4968 Compare December 19, 2018 07:17
@kyungtaak kyungtaak added the testbed1 Review Test Server 1 label Jan 7, 2019
@kyungtaak
Copy link
Contributor

run build
deploy to 1

@kyungtaak kyungtaak merged commit 47da143 into metatron-app:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyungtaak kyungtaak kyungtaak approved these changes

@eltriny eltriny eltriny approved these changes

@babokim babokim Awaiting requested review from babokim

@ufoscw ufoscw Awaiting requested review from ufoscw

@alchan-lee alchan-lee Awaiting requested review from alchan-lee

Assignees
No one assigned
Labels
@chart Chart Component and Widget testbed1 Review Test Server 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@YooYoungmo @ufoscw @metatron-ci-bot @alchan-lee @kyungtaak @eltriny