Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1151 Upgrade base library - angular and echart #1320

Merged
merged 3 commits into from
Feb 12, 2019

Conversation

eltriny
Copy link
Contributor

@eltriny eltriny commented Jan 27, 2019

Description

빌드 속도 개선 및 동일 URL에 대한 이동 개선, 차트 오류 해결 등을 위해서 angular 및 차트의 버전을 올릴 필요가 있습니다.

Related Issue : #1151

How Has This Been Tested?

  1. 각 기능이 정상적으로 동작하는지 확인합니다.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project. it will be added soon
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. it will be added soon
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Additional Context

@eltriny eltriny added the @common Component Name : Common label Jan 27, 2019
@alchan-lee

This comment has been minimized.

@alchan-lee alchan-lee added testbed2 Review Test Server 2 and removed testbed2 Review Test Server 2 labels Jan 28, 2019
@alchan-lee
Copy link
Contributor

영향도가 큰 관계로
테스트 데이터가 충분히 들어있는 metatron-web-05의 8180 포트로 배포해두겠습니다.

@alchan-lee
Copy link
Contributor

@eltriny
업그레이드와 연관이 있는지는 정확히 모르겠지만
배포후에 거의 모든 화면에서 아래와 같은 에러가 발생하고 있습니다.

ERROR TypeError: Cannot read property 'getExtent' of null

image

@alchan-lee
Copy link
Contributor

젠킨스에서 프론트엔드 빌드 시간은
8분 47초에서 4분 14초 정도로 유의미하게 줄어들었네요 😄

@ufoscw
Copy link
Contributor

ufoscw commented Jan 28, 2019

차트 생성 > 맵차트 선택시 위 스크린샷의 콘솔 에러 뜹니다.

@eltriny
Copy link
Contributor Author

eltriny commented Jan 28, 2019

@alchan-lee
콘솔 에러에 대해서 확인하기 위해 재빌드 부탁드립니다.

@alchan-lee
Copy link
Contributor

재배포 완료 되었습니다.

맵도 기본기능들 잘 되는것으로 보이고 콘솔 에러도 사라졌습니다 👍

@alchan-lee
Copy link
Contributor

KPI 차트가 자기 영역을 벗어 나네요 (테스트 환경)

jan-29-2019 13-14-51

@eltriny
Copy link
Contributor Author

eltriny commented Jan 29, 2019

@alchan-lee
KPI 차트가 영역을 벗어나는 문제는 현재 버전에서도 문제가 발생하고 있어.. 별도 이슈로 처리되어야 할거 같습니다..

@kyungtaak
Copy link
Contributor

@eltriny 해당건은 다음 Iteration 에서 진행하면서 이슈를 처리하는게 좋을것 같네요. 릴리즈 끝나고 바로 PR 머지 하도록 할게요.

@kyungtaak kyungtaak requested a review from Cazen February 12, 2019 09:33
Copy link

@Cazen Cazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@kyungtaak kyungtaak merged commit 964b5dd into master Feb 12, 2019
@alchan-lee alchan-lee deleted the f#1151-version_upgrade branch February 21, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@common Component Name : Common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants