Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#667 fix workspace comp in datasource #1424

Merged
merged 6 commits into from
Feb 14, 2019

Conversation

brandon-wonjune
Copy link
Contributor

Description

소유자를 표시할때 username이 같이 표기되도록 수정
2019-02-13 1 12 35

Related Issue :

#667

How Has This Been Tested?

  1. 데이터소스 또는 커넥션 상세화면에서 워크스페이스를 지정하는 팝업 오픈
  2. Owner(소유자) 에서 username이 같이 표기되는지 확인

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project. it will be added soon
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. it will be added soon
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Additional Context

@brandon-wonjune brandon-wonjune added the @datasource Component Name : Datasource/Connection Management label Feb 13, 2019
@kyungtaak
Copy link
Contributor

run build
deploy to 5

@kyungtaak kyungtaak added the testbed5 Review Test Server 5 label Feb 13, 2019
@deidera08
Copy link

User name으로도 검색이 이뤄지면 좋을듯 합니다.
list

검색 결과가 없을 경우 "No result"문구 노출 부탁드려요
noresult

@brandon-wonjune
Copy link
Contributor Author

@deidera08 no result 추가하였습니다

@minjung-cho
Copy link

@brandon-wonjune 영문 이름일 경우, Username이 길어질 수 있을 것 같습니다. 영역을 지금보다 조금 키워 주실 수 있을까요?

@brandon-wonjune
Copy link
Contributor Author

brandon-wonjune commented Feb 13, 2019

@minjung-cho 영역 수정하였습니다
2019-02-13 4 04 59

@ufoscw
Copy link
Contributor

ufoscw commented Feb 13, 2019

run build
deploy to 5

1 similar comment
@alchan-lee
Copy link
Contributor

run build
deploy to 5

ufoscw
ufoscw previously approved these changes Feb 14, 2019
@kyungtaak kyungtaak self-requested a review February 14, 2019 00:39
@kyungtaak
Copy link
Contributor

@minjung-cho @brandon-wonjune 아래처럼 선택하면 글자색이 흐리게 보이는것은 의도된 것인가요?

image

@deidera08
Copy link

@kyungtaak

@minjung-cho @brandon-wonjune 아래처럼 선택하면 글자색이 흐리게 보이는것은 의도된 것인가요?

의도된 바가 아닙니다. 수정요청중입니다

@brandon-wonjune
Copy link
Contributor Author

@deidera08 체크시 글자색이 흐려지는것 제거하였습니다

@kyungtaak
Copy link
Contributor

run build
deploy to 5

@kyungtaak kyungtaak merged commit ad2267f into master Feb 14, 2019
@alchan-lee alchan-lee deleted the f#667-fix_workspace_comp_in_datasource branch February 21, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@datasource Component Name : Datasource/Connection Management testbed5 Review Test Server 5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants