Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1717 Fix ruleIdx when sending rename transform api #1725

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

paigechoi
Copy link
Contributor

@paigechoi paigechoi commented Mar 25, 2019

Description

When rename popup is opened via snapshot create popup and is in edit mode
transform API is failed due to wrong ruleIdx.

룰을 수정하는 중에 스냅샷 생성 팝업에서 Rename을 하려고 하면 ruleIdx가 틀려서 룰이 적용되지 않음

Related Issue :

#1717

How Has This Been Tested?

Check #1717 for details.
1 . Go to dataflow main grid
2 . Add at least 3 ~ 5 rules. (any)
3 . Change one column to '컬럼1'
4 .
image
5 . Rename rule should be applied at the end of the rule.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project. it will be added soon
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. it will be added soon
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Additional Context

- When rename popup is opened via snapshot create popup and is in edit mode
@paigechoi paigechoi added the @dataprep Component Name : Data preparation label Mar 25, 2019
@paigechoi paigechoi self-assigned this Mar 25, 2019
@joohokim1 joohokim1 added the testbed4 Review Test Server 4 label Mar 25, 2019
@joohokim1
Copy link
Contributor

run build
deploy to 4

@joohokim1 joohokim1 merged commit 03fcc2e into master Mar 25, 2019
@alchan-lee alchan-lee deleted the f#1717-fix_rename_fail branch June 17, 2019 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@dataprep Component Name : Data preparation testbed4 Review Test Server 4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants