Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2012 Can not access workbook in a workspace which is allowed anyone to access #2017

Merged
merged 2 commits into from
May 8, 2019
Merged

#2012 Can not access workbook in a workspace which is allowed anyone to access #2017

merged 2 commits into from
May 8, 2019

Conversation

eltriny
Copy link
Contributor

@eltriny eltriny commented May 7, 2019

Description

Can not access workbook in a workspace which is allowed anyone to access

Related Issue : #2012

How Has This Been Tested?

  1. userA allow anyone to access workspaceA
  2. userB enter workspaceA
  3. check userB can access workbook in workspaceA

Need additional checks?

Check that permissions are applied in a normal shared workspace, not in a published workspace.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@eltriny eltriny added the @workspace Component Name : Workspace label May 7, 2019
@kyungtaak
Copy link
Contributor

run build
deploy to 5

@kyungtaak kyungtaak added the testbed5 Review Test Server 5 label May 7, 2019
@kyungtaak
Copy link
Contributor

run build
deploy to 5

@kyungtaak kyungtaak merged commit d60beb2 into master May 8, 2019
@alchan-lee alchan-lee deleted the f#2012-can_not_access_workbook branch May 22, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyungtaak kyungtaak kyungtaak approved these changes

@minhyun2 minhyun2 minhyun2 approved these changes

@ufoscw ufoscw Awaiting requested review from ufoscw

@alchan-lee alchan-lee Awaiting requested review from alchan-lee

Assignees
No one assigned
Labels
testbed5 Review Test Server 5 @workspace Component Name : Workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eltriny @kyungtaak @minhyun2