Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#fn fill all fields of DataConnection class while dataset creation #2197

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

kaypark-skt
Copy link
Contributor

Description

There is a missing field while creating a dataset of Oracle connection.
so dataset creation was failed

Related Issue : None

How Has This Been Tested?

If you can create a dataset of Oracle connection with no error, it is OK

Need additional checks?

make sure that you are using an extension for oracle connection

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@kaypark-skt kaypark-skt added @dataprep Component Name : Data preparation testbed3 Review Test Server 3 labels Jun 10, 2019
@kaypark-skt kaypark-skt self-assigned this Jun 10, 2019
@kaypark-skt
Copy link
Contributor Author

run build
deploy to 3

@joohokim1 joohokim1 added the need to cherry-pick This change need to merge into another base branch. label Jun 11, 2019
@alchan-lee alchan-lee merged commit 5bfae10 into master Jun 11, 2019
@alchan-lee alchan-lee deleted the fn-fix_oracle_type_dataset branch June 17, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@dataprep Component Name : Data preparation need to cherry-pick This change need to merge into another base branch. testbed3 Review Test Server 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants