Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#fn fix csv total row counts #2235

Merged
merged 1 commit into from
Jun 13, 2019
Merged

#fn fix csv total row counts #2235

merged 1 commit into from
Jun 13, 2019

Conversation

minhyun2
Copy link
Contributor

Description

fix csv total row counts

Related Issue :

How Has This Been Tested?

  1. Create datasource with csv file
  2. Check the total count in the preview page

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@minhyun2 minhyun2 added the @datasource Component Name : Datasource/Connection Management label Jun 13, 2019
@minhyun2 minhyun2 added testbed2 Review Test Server 2 bug Something isn't working labels Jun 13, 2019
@minhyun2
Copy link
Contributor Author

run build
deploy to 2

@kyungtaak kyungtaak merged commit 32100af into 3.2.x Jun 13, 2019
alchan-lee pushed a commit that referenced this pull request Jun 14, 2019
@minhyun2 @alchan-lee
#2235 fixed csv total row counts
fc18b66
@alchan-lee alchan-lee deleted the fn-fix_csv_totalcounts branch June 17, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyungtaak kyungtaak kyungtaak approved these changes

@ufoscw ufoscw Awaiting requested review from ufoscw

@alchan-lee alchan-lee Awaiting requested review from alchan-lee

Assignees
No one assigned
Labels
bug Something isn't working @datasource Component Name : Datasource/Connection Management testbed2 Review Test Server 2 to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minhyun2 @kyungtaak