Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos and add comment for extensions #2248

Merged
merged 4 commits into from
Jun 18, 2019
Merged

fix typos and add comment for extensions #2248

merged 4 commits into from
Jun 18, 2019

Conversation

ufoscw
Copy link
Contributor

@ufoscw ufoscw commented Jun 18, 2019

Description

There is no function modification.
fix typos in README.md
add comments for extensions
NullPointerException fixed.

Related Issue :

How Has This Been Tested?

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@ufoscw ufoscw added the @common Component Name : Common label Jun 18, 2019
@ufoscw ufoscw merged commit 3d42754 into master Jun 18, 2019
@kyungtaak kyungtaak added the need to cherry-pick This change need to merge into another base branch. label Jul 2, 2019
alchan-lee pushed a commit that referenced this pull request Jul 2, 2019
@ufoscw @alchan-lee
(#2248) Fix typos and add comment for extensions
d457c87 
* add comment for extensions

* fix typo in README.md

* add discovery version to extension's file name

* fix npe dialect.resultObjectConverter
@alchan-lee alchan-lee deleted the fn-add_comment_for_extensions branch August 2, 2019 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyungtaak kyungtaak kyungtaak approved these changes

@minhyun2 minhyun2 minhyun2 approved these changes

@alchan-lee alchan-lee Awaiting requested review from alchan-lee

Assignees
No one assigned
Labels
@common Component Name : Common need to cherry-pick This change need to merge into another base branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ufoscw @kyungtaak @minhyun2