Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos and add comment for extensions #2248

Merged
merged 4 commits into from Jun 18, 2019

Conversation

Projects
None yet
3 participants
@ufoscw
Copy link
Contributor

commented Jun 18, 2019

Description

There is no function modification.
fix typos in README.md
add comments for extensions
NullPointerException fixed.

Related Issue :

How Has This Been Tested?

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@ufoscw ufoscw requested review from kyungtaak, alchan-lee and minhyun2 Jun 18, 2019

@ufoscw ufoscw added the @common label Jun 18, 2019

@ufoscw ufoscw merged commit 3d42754 into master Jun 18, 2019

1 check passed

CodeFactor No issues found.
Details

alchan-lee added a commit that referenced this pull request Jul 2, 2019

(#2248) Fix typos and add comment for extensions
* add comment for extensions

* fix typo in README.md

* add discovery version to extension's file name

* fix npe dialect.resultObjectConverter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.