Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2241 implement left, right, full outer joins #2254

Closed
wants to merge 3 commits into from
Closed

#2241 implement left, right, full outer joins #2254

wants to merge 3 commits into from

Conversation

joohokim1
Copy link
Contributor

Description

Related Issue : #2241

How Has This Been Tested?

  1. Import A.txt and B.txt
  2. Create a dataflow and add 2 datasets above.
  3. Select join as command and click "Add" button.
  4. Set parameters like this:

스크린샷 2019-06-19 오전 12 44 08

5. Check every join types with "Show result" button. 6. Click "Join" button to check if the result of dataset is as expected. (Optional)

Need additional checks?

Yes, please.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

@joohokim1 joohokim1 added @dataprep Component Name : Data preparation new feature New Feature labels Jun 18, 2019
@joohokim1 joohokim1 added this to the 3.3.0 milestone Jun 18, 2019
@joohokim1 joohokim1 self-assigned this Jun 18, 2019
@joohokim1 joohokim1 added the testbed3 Review Test Server 3 label Jun 18, 2019
@joohokim1
Copy link
Contributor Author

run build
deploy to 3

@joohokim1 joohokim1 removed the new feature New Feature label Jun 18, 2019
@joohokim1
Copy link
Contributor Author

I'm closing and going to remake.

@joohokim1 joohokim1 closed this Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnieHwang AnnieHwang Awaiting requested review from AnnieHwang

@kaypark-skt kaypark-skt Awaiting requested review from kaypark-skt

@jeongeunkwon jeongeunkwon Awaiting requested review from jeongeunkwon

Assignees

@joohokim1 joohokim1

Labels
@dataprep Component Name : Data preparation testbed3 Review Test Server 3
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joohokim1