Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authentication script error in update connection component #2306

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Fix authentication script error in update connection component #2306

merged 1 commit into from
Jul 3, 2019

Conversation

brandon-wonjune
Copy link
Contributor

Description

특정 타입의 database의 커넥션 상세화면에서 데이터를 수정 후 완료를 누를때 script error가 발생하는 현상 수정

Related Issue :

통합테스트

How Has This Been Tested?

  1. 커넥션 생성 (druid)
  2. 1에서 생성한 커넥션 상세화면으로 이동
  3. 커넥션 데이터를 수정하거나 수정하지 않고 done(완료)를 눌렀을떄 script error가 발생하는지 확인

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@brandon-wonjune brandon-wonjune added bug Something isn't working @datasource Component Name : Datasource/Connection Management labels Jul 2, 2019
@ufoscw ufoscw added testbed4 Review Test Server 4 to master and removed testbed4 Review Test Server 4 labels Jul 3, 2019
@ufoscw
Copy link
Contributor

ufoscw commented Jul 3, 2019

run build
deploy to 4

@ufoscw ufoscw merged commit 9bc971e into 3.2.x Jul 3, 2019
alchan-lee pushed a commit that referenced this pull request Jul 5, 2019
@brandon-wonjune @alchan-lee
#2306 fix authentication script error in update connection component
4f9459a
@alchan-lee alchan-lee deleted the fn-fix_connection_update_error branch August 2, 2019 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ufoscw ufoscw ufoscw approved these changes

@kyungtaak kyungtaak Awaiting requested review from kyungtaak

@eltriny eltriny Awaiting requested review from eltriny

@alchan-lee alchan-lee Awaiting requested review from alchan-lee

@minhyun2 minhyun2 Awaiting requested review from minhyun2

Assignees
No one assigned
Labels
bug Something isn't working @datasource Component Name : Datasource/Connection Management testbed4 Review Test Server 4 to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandon-wonjune @ufoscw